qugalet/dwmblocks
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Safeguarded dup2 and close sequence in getcmd

Browse source
This commit is contained in:
Ashish Kumar Yadav 2020-08-24 04:19:45 +05:30
parent d4a726ad78
commit e6844edbf1
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
dwmblocks.c
View file

@ -81,11 +81,13 @@ getcmd(Block *block, int sigval)
case 0: case 0:
close(ConnectionNumber(dpy)); close(ConnectionNumber(dpy));
close(fd[0]); close(fd[0]);
if (dup2(fd[1], STDOUT_FILENO) != STDOUT_FILENO) { if (fd[1] != STDOUT_FILENO) {
perror("getcmd - child - dup2"); if (dup2(fd[1], STDOUT_FILENO) != STDOUT_FILENO) {
exit(1); perror("getcmd - child - dup2");
exit(1);
}
close(fd[1]);
} }
close(fd[1]);
if (sigval == NILL) { if (sigval == NILL) {
char *arg[] = { block->pathu, NULL }; char *arg[] = { block->pathu, NULL };