2023-03-12 15:00:57 +00:00
|
|
|
// GoToSocial
|
|
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
//
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU Affero General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2021-08-25 13:34:33 +00:00
|
|
|
|
2021-06-13 16:42:28 +00:00
|
|
|
package status
|
|
|
|
|
|
|
|
import (
|
2021-08-25 13:34:33 +00:00
|
|
|
"context"
|
2021-06-13 16:42:28 +00:00
|
|
|
"errors"
|
|
|
|
"fmt"
|
|
|
|
|
2021-08-31 13:59:12 +00:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/ap"
|
2021-06-13 16:42:28 +00:00
|
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/id"
|
2023-03-20 18:10:08 +00:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
2021-08-31 13:59:12 +00:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/messages"
|
2021-12-20 14:19:53 +00:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/uris"
|
2021-06-13 16:42:28 +00:00
|
|
|
)
|
|
|
|
|
2023-12-01 14:27:15 +00:00
|
|
|
func (p *Processor) getFaveableStatus(
|
|
|
|
ctx context.Context,
|
|
|
|
requester *gtsmodel.Account,
|
|
|
|
targetID string,
|
|
|
|
) (
|
|
|
|
*gtsmodel.Status,
|
|
|
|
*gtsmodel.StatusFave,
|
|
|
|
gtserror.WithCode,
|
|
|
|
) {
|
|
|
|
// Get target status and ensure it's not a boost.
|
|
|
|
target, errWithCode := p.c.GetVisibleTargetStatus(
|
|
|
|
ctx,
|
|
|
|
requester,
|
|
|
|
targetID,
|
2024-02-09 14:24:49 +00:00
|
|
|
nil, // default freshness
|
2023-12-01 14:27:15 +00:00
|
|
|
)
|
2023-10-25 14:04:53 +00:00
|
|
|
if errWithCode != nil {
|
|
|
|
return nil, nil, errWithCode
|
|
|
|
}
|
|
|
|
|
2023-12-01 14:27:15 +00:00
|
|
|
target, errWithCode = p.c.UnwrapIfBoost(
|
|
|
|
ctx,
|
|
|
|
requester,
|
|
|
|
target,
|
|
|
|
)
|
|
|
|
if errWithCode != nil {
|
|
|
|
return nil, nil, errWithCode
|
|
|
|
}
|
|
|
|
|
|
|
|
fave, err := p.state.DB.GetStatusFave(ctx, requester.ID, target.ID)
|
2023-10-25 14:04:53 +00:00
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
err = fmt.Errorf("getFaveTarget: error checking existing fave: %w", err)
|
|
|
|
return nil, nil, gtserror.NewErrorInternalError(err)
|
|
|
|
}
|
|
|
|
|
2023-12-01 14:27:15 +00:00
|
|
|
return target, fave, nil
|
2023-10-25 14:04:53 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
// FaveCreate adds a fave for the requestingAccount, targeting the given status (no-op if fave already exists).
|
2024-07-24 11:27:42 +00:00
|
|
|
func (p *Processor) FaveCreate(
|
|
|
|
ctx context.Context,
|
|
|
|
requester *gtsmodel.Account,
|
|
|
|
targetStatusID string,
|
|
|
|
) (*apimodel.Status, gtserror.WithCode) {
|
|
|
|
status, existingFave, errWithCode := p.getFaveableStatus(ctx, requester, targetStatusID)
|
2023-03-20 18:10:08 +00:00
|
|
|
if errWithCode != nil {
|
|
|
|
return nil, errWithCode
|
2021-06-13 16:42:28 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
if existingFave != nil {
|
|
|
|
// Status is already faveed.
|
2024-07-24 11:27:42 +00:00
|
|
|
return p.c.GetAPIStatus(ctx, requester, status)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ensure valid fave target for requester.
|
|
|
|
policyResult, err := p.intFilter.StatusLikeable(ctx,
|
|
|
|
requester,
|
|
|
|
status,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
err := gtserror.Newf("error seeing if status %s is likeable: %w", status.ID, err)
|
|
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if policyResult.Forbidden() {
|
|
|
|
const errText = "you do not have permission to fave this status"
|
|
|
|
err := gtserror.New(errText)
|
|
|
|
return nil, gtserror.NewErrorForbidden(err, errText)
|
2021-06-13 16:42:28 +00:00
|
|
|
}
|
|
|
|
|
2024-07-26 10:04:28 +00:00
|
|
|
// Derive pendingApproval
|
|
|
|
// and preapproved status.
|
|
|
|
var (
|
|
|
|
pendingApproval bool
|
|
|
|
preApproved bool
|
|
|
|
)
|
|
|
|
|
2024-07-24 11:27:42 +00:00
|
|
|
switch {
|
|
|
|
case policyResult.WithApproval():
|
|
|
|
// We're allowed to do
|
|
|
|
// this pending approval.
|
|
|
|
pendingApproval = true
|
|
|
|
|
|
|
|
case policyResult.MatchedOnCollection():
|
|
|
|
// We're permitted to do this, but since
|
|
|
|
// we matched due to presence in a followers
|
|
|
|
// or following collection, we should mark
|
2024-07-26 10:04:28 +00:00
|
|
|
// as pending approval and wait until we can
|
|
|
|
// prove it's been Accepted by the target.
|
2024-07-24 11:27:42 +00:00
|
|
|
pendingApproval = true
|
|
|
|
|
2024-07-26 10:04:28 +00:00
|
|
|
if *status.Local {
|
|
|
|
// If the target is local we don't need
|
|
|
|
// to wait for an Accept from remote,
|
|
|
|
// we can just preapprove it and have
|
|
|
|
// the processor create the Accept.
|
|
|
|
preApproved = true
|
|
|
|
}
|
|
|
|
|
2024-07-24 11:27:42 +00:00
|
|
|
case policyResult.Permitted():
|
|
|
|
// We're permitted to do this
|
|
|
|
// based on another kind of match.
|
|
|
|
pendingApproval = false
|
|
|
|
}
|
|
|
|
|
|
|
|
status.PendingApproval = &pendingApproval
|
|
|
|
|
|
|
|
// Create a new fave, marking it
|
|
|
|
// as pending approval if necessary.
|
2023-03-20 18:10:08 +00:00
|
|
|
faveID := id.NewULID()
|
|
|
|
gtsFave := >smodel.StatusFave{
|
|
|
|
ID: faveID,
|
2024-07-24 11:27:42 +00:00
|
|
|
AccountID: requester.ID,
|
|
|
|
Account: requester,
|
|
|
|
TargetAccountID: status.AccountID,
|
|
|
|
TargetAccount: status.Account,
|
|
|
|
StatusID: status.ID,
|
|
|
|
Status: status,
|
|
|
|
URI: uris.GenerateURIForLike(requester.Username, faveID),
|
2024-07-26 10:04:28 +00:00
|
|
|
PreApproved: preApproved,
|
2024-07-24 11:27:42 +00:00
|
|
|
PendingApproval: &pendingApproval,
|
2021-06-13 16:42:28 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
if err := p.state.DB.PutStatusFave(ctx, gtsFave); err != nil {
|
|
|
|
err = fmt.Errorf("FaveCreate: error putting fave in database: %w", err)
|
|
|
|
return nil, gtserror.NewErrorInternalError(err)
|
2021-06-13 16:42:28 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
// Process new status fave side effects.
|
2024-04-26 12:50:46 +00:00
|
|
|
p.state.Workers.Client.Queue.Push(&messages.FromClientAPI{
|
2023-03-20 18:10:08 +00:00
|
|
|
APObjectType: ap.ActivityLike,
|
|
|
|
APActivityType: ap.ActivityCreate,
|
|
|
|
GTSModel: gtsFave,
|
2024-07-24 11:27:42 +00:00
|
|
|
Origin: requester,
|
|
|
|
Target: status.Account,
|
2023-03-20 18:10:08 +00:00
|
|
|
})
|
2021-06-13 16:42:28 +00:00
|
|
|
|
2024-07-24 11:27:42 +00:00
|
|
|
return p.c.GetAPIStatus(ctx, requester, status)
|
2021-06-13 16:42:28 +00:00
|
|
|
}
|
2023-02-22 15:05:26 +00:00
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
// FaveRemove removes a fave for the requesting account, targeting the given status (no-op if fave doesn't exist).
|
2023-02-22 15:05:26 +00:00
|
|
|
func (p *Processor) FaveRemove(ctx context.Context, requestingAccount *gtsmodel.Account, targetStatusID string) (*apimodel.Status, gtserror.WithCode) {
|
2023-10-25 14:04:53 +00:00
|
|
|
targetStatus, existingFave, errWithCode := p.getFaveableStatus(ctx, requestingAccount, targetStatusID)
|
2023-03-20 18:10:08 +00:00
|
|
|
if errWithCode != nil {
|
|
|
|
return nil, errWithCode
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
if existingFave == nil {
|
|
|
|
// Status isn't faveed.
|
2023-10-25 14:04:53 +00:00
|
|
|
return p.c.GetAPIStatus(ctx, requestingAccount, targetStatus)
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
// We have a fave to remove.
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 13:03:14 +00:00
|
|
|
if err := p.state.DB.DeleteStatusFaveByID(ctx, existingFave.ID); err != nil {
|
2023-03-20 18:10:08 +00:00
|
|
|
err = fmt.Errorf("FaveRemove: error removing status fave: %w", err)
|
|
|
|
return nil, gtserror.NewErrorInternalError(err)
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
// Process remove status fave side effects.
|
2024-04-26 12:50:46 +00:00
|
|
|
p.state.Workers.Client.Queue.Push(&messages.FromClientAPI{
|
2023-03-20 18:10:08 +00:00
|
|
|
APObjectType: ap.ActivityLike,
|
|
|
|
APActivityType: ap.ActivityUndo,
|
|
|
|
GTSModel: existingFave,
|
2024-04-26 12:50:46 +00:00
|
|
|
Origin: requestingAccount,
|
|
|
|
Target: targetStatus.Account,
|
2023-03-20 18:10:08 +00:00
|
|
|
})
|
2023-02-22 15:05:26 +00:00
|
|
|
|
2023-10-25 14:04:53 +00:00
|
|
|
return p.c.GetAPIStatus(ctx, requestingAccount, targetStatus)
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// FavedBy returns a slice of accounts that have liked the given status, filtered according to privacy settings.
|
|
|
|
func (p *Processor) FavedBy(ctx context.Context, requestingAccount *gtsmodel.Account, targetStatusID string) ([]*apimodel.Account, gtserror.WithCode) {
|
2023-12-15 14:24:39 +00:00
|
|
|
targetStatus, errWithCode := p.c.GetVisibleTargetStatus(ctx,
|
|
|
|
requestingAccount,
|
|
|
|
targetStatusID,
|
2024-02-09 14:24:49 +00:00
|
|
|
nil, // default freshness
|
2023-12-15 14:24:39 +00:00
|
|
|
)
|
2023-03-20 18:10:08 +00:00
|
|
|
if errWithCode != nil {
|
|
|
|
return nil, errWithCode
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
2023-08-04 11:28:33 +00:00
|
|
|
statusFaves, err := p.state.DB.GetStatusFaves(ctx, targetStatus.ID)
|
2023-02-22 15:05:26 +00:00
|
|
|
if err != nil {
|
2023-03-20 18:10:08 +00:00
|
|
|
return nil, gtserror.NewErrorNotFound(fmt.Errorf("FavedBy: error seeing who faved status: %s", err))
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
2023-03-20 18:10:08 +00:00
|
|
|
// For each fave, ensure that we're only showing
|
|
|
|
// the requester accounts that they don't block,
|
|
|
|
// and which don't block them.
|
|
|
|
apiAccounts := make([]*apimodel.Account, 0, len(statusFaves))
|
2023-02-22 15:05:26 +00:00
|
|
|
for _, fave := range statusFaves {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 13:03:14 +00:00
|
|
|
if blocked, err := p.state.DB.IsEitherBlocked(ctx, requestingAccount.ID, fave.AccountID); err != nil {
|
2023-03-20 18:10:08 +00:00
|
|
|
err = fmt.Errorf("FavedBy: error checking blocks: %w", err)
|
|
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
|
|
} else if blocked {
|
|
|
|
continue
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
2023-03-20 18:10:08 +00:00
|
|
|
|
|
|
|
if fave.Account == nil {
|
|
|
|
// Account isn't set for some reason, just skip.
|
|
|
|
log.WithContext(ctx).WithField("fave", fave).Warn("fave had no associated account")
|
|
|
|
continue
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
|
2023-09-23 16:44:11 +00:00
|
|
|
apiAccount, err := p.converter.AccountToAPIAccountPublic(ctx, fave.Account)
|
2023-02-22 15:05:26 +00:00
|
|
|
if err != nil {
|
2023-03-20 18:10:08 +00:00
|
|
|
err = fmt.Errorf("FavedBy: error converting account %s to frontend representation: %w", fave.AccountID, err)
|
|
|
|
return nil, gtserror.NewErrorInternalError(err)
|
2023-02-22 15:05:26 +00:00
|
|
|
}
|
|
|
|
apiAccounts = append(apiAccounts, apiAccount)
|
|
|
|
}
|
|
|
|
|
|
|
|
return apiAccounts, nil
|
|
|
|
}
|