qugalet/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2024-11-22 11:46:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[bugfix] only check replyTo visibility during permission checks IF status is local (#2757)

Browse source
This commit is contained in:
kim 2024-03-14 16:55:35 +00:00 committed by GitHub
parent 92bf1f779b
commit 459e75a9db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
internal/federation/dereferencing/status.go
View file

@ -621,6 +621,10 @@ func (d *Dereferencer) isPermittedStatus(
return onFail() return onFail()
} }
// Default to true
permitted = true
if *status.InReplyTo.Local {
// Check visibility of inReplyTo to status author. // Check visibility of inReplyTo to status author.
permitted, err = d.visibility.StatusVisible(ctx, permitted, err = d.visibility.StatusVisible(ctx,
status.Account, status.Account,
@ -629,11 +633,11 @@ func (d *Dereferencer) isPermittedStatus(
if err != nil { if err != nil {
return false, gtserror.Newf("error checking in-reply-to visibility: %w", err) return false, gtserror.Newf("error checking in-reply-to visibility: %w", err)
} }
}
if permitted && if permitted &&
*status.InReplyTo.Replyable { *status.InReplyTo.Replyable {
// This status is visible AND // Status is reply-able to.
// replyable, in this economy?!
return true, nil return true, nil
} }