From 4b7d7f9b8bb31f55dff410f0e6e9930d2823f9e0 Mon Sep 17 00:00:00 2001 From: vdyotte Date: Tue, 24 Sep 2024 15:45:13 -0400 Subject: [PATCH] Feat: document new hide boots setting --- docs/user_guide/settings.md | 11 ++++++++--- internal/api/client/statuses/statuscreate_test.go | 2 +- internal/cache/size.go | 3 +-- internal/processing/account/rss.go | 4 ++-- internal/processing/account/statuses.go | 1 - 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/docs/user_guide/settings.md b/docs/user_guide/settings.md index 66452578d..5f1b6a013 100644 --- a/docs/user_guide/settings.md +++ b/docs/user_guide/settings.md @@ -88,9 +88,9 @@ This setting does not affect visibility of your posts over the ActivityPub proto !!! warning Be aware that changes to this setting also apply retroactively. - + That is, if you previously made a post on Unlisted visibility, while set to show only Public posts on your profile, and you change this setting to show Public and Unlisted, then the Unlisted post you previously made will be visible on your profile alongside your Public posts. - + Likewise, if you change this setting to show no posts, then all your posts will be hidden from your profile, regardless of when you created them, and what this option was set to at the time. This will apply until you change this setting again. !!! tip @@ -134,6 +134,11 @@ This feed only includes posts set as 'Public' (see [Privacy Settings](./posts.md !!! warning Exposing your RSS feed allows *anyone* to subscribe to updates on your Public posts anonymously, bypassing follows and follow requests. +#### Hide boosts from your public page + +By default, GoToSocial will display posts boosted by you on your public web profile. If you do not wish to display them, You can hide them by checking this box. + + #### Hide Who You Follow / Are Followed By By default, GoToSocial shows your following/followers counts on your public web profile, and allows others to see who you follow and are followed by. This can be useful for account discovery purposes. However, for privacy + safety reasons you may wish to hide these counts, and to hide your following/followers lists from other accounts. You can do this by checking this box. @@ -196,7 +201,7 @@ If you want to reset all your policies to the initial defaults, you can click on !!! danger While GoToSocial respects interaction policies, it is not guaranteed that other server softwares will, and it is possible that accounts on other servers will still send out replies and boosts of your post to their followers, even if your instance forbids these interactions. - + As more ActivityPub servers roll out support for interaction policies, this issue will hopefully diminish, but in the meantime GoToSocial can offer only a "best effort" attempt to restrict interactions with your posts according to the policies you have set. ## Email & Password diff --git a/internal/api/client/statuses/statuscreate_test.go b/internal/api/client/statuses/statuscreate_test.go index aab66f849..d32feb6c7 100644 --- a/internal/api/client/statuses/statuscreate_test.go +++ b/internal/api/client/statuses/statuscreate_test.go @@ -447,7 +447,7 @@ func (suite *StatusCreateTestSuite) TestPostNewStatusMessedUpIntPolicy() { suite.Equal(http.StatusBadRequest, recorder.Code) // We should have a helpful error - // message telling us how we screwed up. + // message telling us how we screwed up. suite.Equal(`{ "error": "Bad Request: error converting followers_only.can_reply.always: policyURI public is not feasible for visibility followers_only" }`, out) diff --git a/internal/cache/size.go b/internal/cache/size.go index f3398dece..8367e4c46 100644 --- a/internal/cache/size.go +++ b/internal/cache/size.go @@ -38,7 +38,7 @@ exampleURI = "https://social.bbc/users/ItsMePrinceCharlesInit" exampleText = ` oh no me nan's gone and done it :shocked: - + she fuckin killed the king :regicide: nan what have you done :shocked: @@ -277,7 +277,6 @@ func sizeofAccountSettings() uintptr { StatusContentType: "text/plain", CustomCSS: exampleText, EnableRSS: util.Ptr(true), - HideBoosts: util.Ptr(false), HideCollections: util.Ptr(false), })) } diff --git a/internal/processing/account/rss.go b/internal/processing/account/rss.go index fb5f56108..22ba0fe42 100644 --- a/internal/processing/account/rss.go +++ b/internal/processing/account/rss.go @@ -123,8 +123,8 @@ func (p *Processor) GetRSSFeedForUsername(ctx context.Context, username string) } // Add each status to the rss feed. - for _, s := range statuses { - item, err := p.converter.StatusToRSSItem(ctx, s) + for _, status := range statuses { + item, err := p.converter.StatusToRSSItem(ctx, status) if err != nil { err = gtserror.Newf("error converting status to feed item: %w", err) return "", gtserror.NewErrorInternalError(err) diff --git a/internal/processing/account/statuses.go b/internal/processing/account/statuses.go index 3a92d73ee..8029a460b 100644 --- a/internal/processing/account/statuses.go +++ b/internal/processing/account/statuses.go @@ -184,7 +184,6 @@ func (p *Processor) WebStatusesGet( log.Errorf(ctx, "error convering to web status: %v", err) continue } - items = append(items, item) }