mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-11-27 06:06:38 +00:00
84279f6a6a
* improvements to caching for lists and relationship to accounts / follows * fix nil panic in AddToList() * ensure list related caches are correctly invalidated * ensure returned ID lists are ordered correctly * bump go-structr to v0.8.9 (returns early if zero uncached keys to be loaded) * remove zero checks in uncached key load functions (go-structr now handles this) * fix issues after rebase on upstream/main * update the expected return order of CSV exports (since list entries are now down by entry creation date) * rename some funcs, allow deleting list entries for multiple follow IDs at a time, fix up more tests * use returning statements on delete to get cache invalidation info * fixes to recent database delete changes * fix broken list entries delete sql * remove unused db function * update remainder of delete functions to behave in similar way, some other small tweaks * fix delete user sql, allow returning on err no entries * uncomment + fix list database tests * update remaining list tests * update envparsing test * add comments to each specific key being invalidated * add more cache invalidation explanatory comments * whoops; actually delete poll votes from database in the DeletePollByID() func * remove added but-commented-out field * improved comment regarding paging being disabled * make cache invalidation comments match what's actually happening * fix up delete query comments to match what is happening * rename function to read a bit better * don't use ErrNoEntries on delete when not needed (it's only needed for a RETURNING call) * update function name in test * move list exclusivity check to AFTER eligibility check. use log.Panic() instead of panic() * use the poll_id column in poll_votes for selecting votes in poll ID * fix function name
400 lines
11 KiB
Go
400 lines
11 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package bundb
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"slices"
|
|
"time"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtscontext"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
"github.com/superseriousbusiness/gotosocial/internal/util"
|
|
"github.com/uptrace/bun"
|
|
)
|
|
|
|
func (r *relationshipDB) GetFollowByID(ctx context.Context, id string) (*gtsmodel.Follow, error) {
|
|
return r.getFollow(
|
|
ctx,
|
|
"ID",
|
|
func(follow *gtsmodel.Follow) error {
|
|
return r.db.NewSelect().
|
|
Model(follow).
|
|
Where("? = ?", bun.Ident("id"), id).
|
|
Scan(ctx)
|
|
},
|
|
id,
|
|
)
|
|
}
|
|
|
|
func (r *relationshipDB) GetFollowByURI(ctx context.Context, uri string) (*gtsmodel.Follow, error) {
|
|
return r.getFollow(
|
|
ctx,
|
|
"URI",
|
|
func(follow *gtsmodel.Follow) error {
|
|
return r.db.NewSelect().
|
|
Model(follow).
|
|
Where("? = ?", bun.Ident("uri"), uri).
|
|
Scan(ctx)
|
|
},
|
|
uri,
|
|
)
|
|
}
|
|
|
|
func (r *relationshipDB) GetFollow(ctx context.Context, sourceAccountID string, targetAccountID string) (*gtsmodel.Follow, error) {
|
|
return r.getFollow(
|
|
ctx,
|
|
"AccountID,TargetAccountID",
|
|
func(follow *gtsmodel.Follow) error {
|
|
return r.db.NewSelect().
|
|
Model(follow).
|
|
Where("? = ?", bun.Ident("account_id"), sourceAccountID).
|
|
Where("? = ?", bun.Ident("target_account_id"), targetAccountID).
|
|
Scan(ctx)
|
|
},
|
|
sourceAccountID,
|
|
targetAccountID,
|
|
)
|
|
}
|
|
|
|
func (r *relationshipDB) GetFollowsByIDs(ctx context.Context, ids []string) ([]*gtsmodel.Follow, error) {
|
|
// Load all follow IDs via cache loader callbacks.
|
|
follows, err := r.state.Caches.DB.Follow.LoadIDs("ID",
|
|
ids,
|
|
func(uncached []string) ([]*gtsmodel.Follow, error) {
|
|
// Preallocate expected length of uncached follows.
|
|
follows := make([]*gtsmodel.Follow, 0, len(uncached))
|
|
|
|
// Perform database query scanning
|
|
// the remaining (uncached) IDs.
|
|
if err := r.db.NewSelect().
|
|
Model(&follows).
|
|
Where("? IN (?)", bun.Ident("id"), bun.In(uncached)).
|
|
Scan(ctx); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return follows, nil
|
|
},
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Reorder the follows by their
|
|
// IDs to ensure in correct order.
|
|
getID := func(f *gtsmodel.Follow) string { return f.ID }
|
|
util.OrderBy(follows, ids, getID)
|
|
|
|
if gtscontext.Barebones(ctx) {
|
|
// no need to fully populate.
|
|
return follows, nil
|
|
}
|
|
|
|
// Populate all loaded follows, removing those we fail to
|
|
// populate (removes needing so many nil checks everywhere).
|
|
follows = slices.DeleteFunc(follows, func(follow *gtsmodel.Follow) bool {
|
|
if err := r.PopulateFollow(ctx, follow); err != nil {
|
|
log.Errorf(ctx, "error populating follow %s: %v", follow.ID, err)
|
|
return true
|
|
}
|
|
return false
|
|
})
|
|
|
|
return follows, nil
|
|
}
|
|
|
|
func (r *relationshipDB) IsFollowing(ctx context.Context, sourceAccountID string, targetAccountID string) (bool, error) {
|
|
follow, err := r.GetFollow(
|
|
gtscontext.SetBarebones(ctx),
|
|
sourceAccountID,
|
|
targetAccountID,
|
|
)
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
return false, err
|
|
}
|
|
return (follow != nil), nil
|
|
}
|
|
|
|
func (r *relationshipDB) IsMutualFollowing(ctx context.Context, accountID1 string, accountID2 string) (bool, error) {
|
|
// make sure account 1 follows account 2
|
|
f1, err := r.IsFollowing(ctx,
|
|
accountID1,
|
|
accountID2,
|
|
)
|
|
if !f1 /* f1 = false when err != nil */ {
|
|
return false, err
|
|
}
|
|
|
|
// make sure account 2 follows account 1
|
|
f2, err := r.IsFollowing(ctx,
|
|
accountID2,
|
|
accountID1,
|
|
)
|
|
if !f2 /* f2 = false when err != nil */ {
|
|
return false, err
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func (r *relationshipDB) getFollow(ctx context.Context, lookup string, dbQuery func(*gtsmodel.Follow) error, keyParts ...any) (*gtsmodel.Follow, error) {
|
|
// Fetch follow from database cache with loader callback
|
|
follow, err := r.state.Caches.DB.Follow.LoadOne(lookup, func() (*gtsmodel.Follow, error) {
|
|
var follow gtsmodel.Follow
|
|
|
|
// Not cached! Perform database query
|
|
if err := dbQuery(&follow); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &follow, nil
|
|
}, keyParts...)
|
|
if err != nil {
|
|
// error already processed
|
|
return nil, err
|
|
}
|
|
|
|
if gtscontext.Barebones(ctx) {
|
|
// Only a barebones model was requested.
|
|
return follow, nil
|
|
}
|
|
|
|
if err := r.state.DB.PopulateFollow(ctx, follow); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return follow, nil
|
|
}
|
|
|
|
func (r *relationshipDB) PopulateFollow(ctx context.Context, follow *gtsmodel.Follow) error {
|
|
var (
|
|
err error
|
|
errs = gtserror.NewMultiError(2)
|
|
)
|
|
|
|
if follow.Account == nil {
|
|
// Follow account is not set, fetch from the database.
|
|
follow.Account, err = r.state.DB.GetAccountByID(
|
|
gtscontext.SetBarebones(ctx),
|
|
follow.AccountID,
|
|
)
|
|
if err != nil {
|
|
errs.Appendf("error populating follow account: %w", err)
|
|
}
|
|
}
|
|
|
|
if follow.TargetAccount == nil {
|
|
// Follow target account is not set, fetch from the database.
|
|
follow.TargetAccount, err = r.state.DB.GetAccountByID(
|
|
gtscontext.SetBarebones(ctx),
|
|
follow.TargetAccountID,
|
|
)
|
|
if err != nil {
|
|
errs.Appendf("error populating follow target account: %w", err)
|
|
}
|
|
}
|
|
|
|
return errs.Combine()
|
|
}
|
|
|
|
func (r *relationshipDB) PutFollow(ctx context.Context, follow *gtsmodel.Follow) error {
|
|
return r.state.Caches.DB.Follow.Store(follow, func() error {
|
|
_, err := r.db.NewInsert().Model(follow).Exec(ctx)
|
|
return err
|
|
})
|
|
}
|
|
|
|
func (r *relationshipDB) UpdateFollow(ctx context.Context, follow *gtsmodel.Follow, columns ...string) error {
|
|
follow.UpdatedAt = time.Now()
|
|
if len(columns) > 0 {
|
|
// If we're updating by column, ensure "updated_at" is included.
|
|
columns = append(columns, "updated_at")
|
|
}
|
|
|
|
return r.state.Caches.DB.Follow.Store(follow, func() error {
|
|
if _, err := r.db.NewUpdate().
|
|
Model(follow).
|
|
Where("? = ?", bun.Ident("follow.id"), follow.ID).
|
|
Column(columns...).
|
|
Exec(ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
})
|
|
}
|
|
|
|
func (r *relationshipDB) DeleteFollow(
|
|
ctx context.Context,
|
|
sourceAccountID string,
|
|
targetAccountID string,
|
|
) error {
|
|
|
|
// Gather necessary fields from
|
|
// deleted for cache invaliation.
|
|
var deleted gtsmodel.Follow
|
|
deleted.AccountID = sourceAccountID
|
|
deleted.TargetAccountID = targetAccountID
|
|
|
|
// Delete follow from origin
|
|
// account, to targeting account,
|
|
// returning the deleted models.
|
|
if _, err := r.db.NewDelete().
|
|
Model(&deleted).
|
|
Where("? = ?", bun.Ident("account_id"), sourceAccountID).
|
|
Where("? = ?", bun.Ident("target_account_id"), targetAccountID).
|
|
Returning("?", bun.Ident("id")).
|
|
Exec(ctx); err != nil &&
|
|
!errors.Is(err, db.ErrNoEntries) {
|
|
return err
|
|
}
|
|
|
|
// Invalidate cached follow with source / target account IDs,
|
|
// manually calling invalidate hook in case it isn't cached.
|
|
r.state.Caches.DB.Follow.Invalidate("AccountID,TargetAccountID",
|
|
sourceAccountID, targetAccountID)
|
|
r.state.Caches.OnInvalidateFollow(&deleted)
|
|
|
|
// Delete every list entry that was created targetting this follow ID.
|
|
if err := r.state.DB.DeleteAllListEntriesByFollows(ctx, deleted.ID); err != nil {
|
|
return gtserror.Newf("error deleting list entries: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (r *relationshipDB) DeleteFollowByID(ctx context.Context, id string) error {
|
|
// Gather necessary fields from
|
|
// deleted for cache invaliation.
|
|
var deleted gtsmodel.Follow
|
|
deleted.ID = id
|
|
|
|
// Delete follow with given ID,
|
|
// returning the deleted models.
|
|
if _, err := r.db.NewDelete().
|
|
Model(&deleted).
|
|
Where("? = ?", bun.Ident("id"), id).
|
|
Returning("?, ?",
|
|
bun.Ident("account_id"),
|
|
bun.Ident("target_account_id"),
|
|
).
|
|
Exec(ctx); err != nil &&
|
|
!errors.Is(err, db.ErrNoEntries) {
|
|
return err
|
|
}
|
|
|
|
// Invalidate cached follow with ID, manually
|
|
// call invalidate hook in case not cached.
|
|
r.state.Caches.DB.Follow.Invalidate("ID", id)
|
|
r.state.Caches.OnInvalidateFollow(&deleted)
|
|
|
|
// Delete every list entry that was created targetting this follow ID.
|
|
if err := r.state.DB.DeleteAllListEntriesByFollows(ctx, id); err != nil {
|
|
return gtserror.Newf("error deleting list entries: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (r *relationshipDB) DeleteFollowByURI(ctx context.Context, uri string) error {
|
|
// Gather necessary fields from
|
|
// deleted for cache invaliation.
|
|
var deleted gtsmodel.Follow
|
|
|
|
// Delete follow with given URI,
|
|
// returning the deleted models.
|
|
if _, err := r.db.NewDelete().
|
|
Model(&deleted).
|
|
Where("? = ?", bun.Ident("uri"), uri).
|
|
Returning("?, ?, ?",
|
|
bun.Ident("id"),
|
|
bun.Ident("account_id"),
|
|
bun.Ident("target_account_id"),
|
|
).
|
|
Exec(ctx); err != nil &&
|
|
!errors.Is(err, db.ErrNoEntries) {
|
|
return err
|
|
}
|
|
|
|
// Invalidate cached follow with URI, manually
|
|
// call invalidate hook in case not cached.
|
|
r.state.Caches.DB.Follow.Invalidate("URI", uri)
|
|
r.state.Caches.OnInvalidateFollow(&deleted)
|
|
|
|
// Delete every list entry that was created targetting this follow ID.
|
|
if err := r.state.DB.DeleteAllListEntriesByFollows(ctx, deleted.ID); err != nil {
|
|
return gtserror.Newf("error deleting list entries: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (r *relationshipDB) DeleteAccountFollows(ctx context.Context, accountID string) error {
|
|
// Gather necessary fields from
|
|
// deleted for cache invaliation.
|
|
var deleted []*gtsmodel.Follow
|
|
|
|
// Delete all follows either from
|
|
// account, or targeting account,
|
|
// returning the deleted models.
|
|
if _, err := r.db.NewDelete().
|
|
Model(&deleted).
|
|
WhereOr("? = ? OR ? = ?",
|
|
bun.Ident("account_id"),
|
|
accountID,
|
|
bun.Ident("target_account_id"),
|
|
accountID,
|
|
).
|
|
Returning("?, ?, ?",
|
|
bun.Ident("id"),
|
|
bun.Ident("account_id"),
|
|
bun.Ident("target_account_id"),
|
|
).
|
|
Exec(ctx); err != nil &&
|
|
!errors.Is(err, db.ErrNoEntries) {
|
|
return err
|
|
}
|
|
|
|
// Gather the follow IDs that were deleted for removing related list entries.
|
|
followIDs := util.Gather(nil, deleted, func(follow *gtsmodel.Follow) string {
|
|
return follow.ID
|
|
})
|
|
|
|
// Delete every list entry that was created targetting any of these follow IDs.
|
|
if err := r.state.DB.DeleteAllListEntriesByFollows(ctx, followIDs...); err != nil {
|
|
return gtserror.Newf("error deleting list entries: %w", err)
|
|
}
|
|
|
|
// Invalidate all account's incoming / outoing follows.
|
|
r.state.Caches.DB.Follow.Invalidate("AccountID", accountID)
|
|
r.state.Caches.DB.Follow.Invalidate("TargetAccountID", accountID)
|
|
|
|
// In case not all follow were in
|
|
// cache, manually call invalidate hooks.
|
|
for _, follow := range deleted {
|
|
r.state.Caches.OnInvalidateFollow(follow)
|
|
}
|
|
|
|
return nil
|
|
}
|