mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-11-23 12:16:38 +00:00
84279f6a6a
* improvements to caching for lists and relationship to accounts / follows * fix nil panic in AddToList() * ensure list related caches are correctly invalidated * ensure returned ID lists are ordered correctly * bump go-structr to v0.8.9 (returns early if zero uncached keys to be loaded) * remove zero checks in uncached key load functions (go-structr now handles this) * fix issues after rebase on upstream/main * update the expected return order of CSV exports (since list entries are now down by entry creation date) * rename some funcs, allow deleting list entries for multiple follow IDs at a time, fix up more tests * use returning statements on delete to get cache invalidation info * fixes to recent database delete changes * fix broken list entries delete sql * remove unused db function * update remainder of delete functions to behave in similar way, some other small tweaks * fix delete user sql, allow returning on err no entries * uncomment + fix list database tests * update remaining list tests * update envparsing test * add comments to each specific key being invalidated * add more cache invalidation explanatory comments * whoops; actually delete poll votes from database in the DeletePollByID() func * remove added but-commented-out field * improved comment regarding paging being disabled * make cache invalidation comments match what's actually happening * fix up delete query comments to match what is happening * rename function to read a bit better * don't use ErrNoEntries on delete when not needed (it's only needed for a RETURNING call) * update function name in test * move list exclusivity check to AFTER eligibility check. use log.Panic() instead of panic() * use the poll_id column in poll_votes for selecting votes in poll ID * fix function name
220 lines
6.8 KiB
Go
220 lines
6.8 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package common
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/federation/dereferencing"
|
|
statusfilter "github.com/superseriousbusiness/gotosocial/internal/filter/status"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
)
|
|
|
|
// GetTargetStatusBy fetches the target status with db load
|
|
// function, given the authorized (or, nil) requester's
|
|
// account. This returns an approprate gtserror.WithCode
|
|
// accounting for not found and visibility to requester.
|
|
//
|
|
// window can be used to force refresh of the target if it's
|
|
// deemed to be stale. Falls back to default window if nil.
|
|
func (p *Processor) GetTargetStatusBy(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
getTargetFromDB func() (*gtsmodel.Status, error),
|
|
window *dereferencing.FreshnessWindow,
|
|
) (
|
|
status *gtsmodel.Status,
|
|
visible bool,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
// Fetch the target status from db.
|
|
target, err := getTargetFromDB()
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
return nil, false, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
if target == nil {
|
|
// DB loader could not find status in database.
|
|
const text = "target status not found"
|
|
return nil, false, gtserror.NewErrorNotFound(
|
|
errors.New(text),
|
|
text,
|
|
)
|
|
}
|
|
|
|
// Check whether target status is visible to requesting account.
|
|
visible, err = p.visFilter.StatusVisible(ctx, requester, target)
|
|
if err != nil {
|
|
return nil, false, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
if requester != nil && visible {
|
|
// Only refresh status if visible to requester,
|
|
// and there is *authorized* requester to prevent
|
|
// a possible DOS vector for unauthorized clients.
|
|
latest, _, err := p.federator.RefreshStatus(ctx,
|
|
requester.Username,
|
|
target,
|
|
nil,
|
|
window,
|
|
)
|
|
if err != nil {
|
|
log.Errorf(ctx, "error refreshing target %s: %v", target.URI, err)
|
|
return target, visible, nil
|
|
}
|
|
|
|
// Set latest.
|
|
target = latest
|
|
}
|
|
|
|
return target, visible, nil
|
|
}
|
|
|
|
// GetVisibleTargetStatus calls GetTargetStatusBy(),
|
|
// but converts a non-visible result to not-found error.
|
|
//
|
|
// window can be used to force refresh of the target if it's
|
|
// deemed to be stale. Falls back to default window if nil.
|
|
func (p *Processor) GetVisibleTargetStatusBy(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
getTargetFromDB func() (*gtsmodel.Status, error),
|
|
window *dereferencing.FreshnessWindow,
|
|
) (
|
|
status *gtsmodel.Status,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
// Fetch the target status by ID from the database.
|
|
target, visible, errWithCode := p.GetTargetStatusBy(ctx,
|
|
requester,
|
|
getTargetFromDB,
|
|
window,
|
|
)
|
|
if errWithCode != nil {
|
|
return nil, errWithCode
|
|
}
|
|
|
|
if !visible {
|
|
// Target should not be seen by requester.
|
|
const text = "target status not found"
|
|
return nil, gtserror.NewErrorNotFound(
|
|
errors.New(text),
|
|
text,
|
|
)
|
|
}
|
|
|
|
return target, nil
|
|
}
|
|
|
|
// GetVisibleTargetStatus calls GetVisibleTargetStatusBy(),
|
|
// passing in a database function that fetches by status ID.
|
|
//
|
|
// window can be used to force refresh of the target if it's
|
|
// deemed to be stale. Falls back to default window if nil.
|
|
func (p *Processor) GetVisibleTargetStatus(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
targetID string,
|
|
window *dereferencing.FreshnessWindow,
|
|
) (
|
|
status *gtsmodel.Status,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
return p.GetVisibleTargetStatusBy(ctx, requester, func() (*gtsmodel.Status, error) {
|
|
return p.state.DB.GetStatusByID(ctx, targetID)
|
|
}, window)
|
|
}
|
|
|
|
// UnwrapIfBoost "unwraps" the given status if
|
|
// it's a boost wrapper, by returning the boosted
|
|
// status it targets (pending visibility checks).
|
|
//
|
|
// Just returns the input status if it's not a boost.
|
|
func (p *Processor) UnwrapIfBoost(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
status *gtsmodel.Status,
|
|
) (*gtsmodel.Status, gtserror.WithCode) {
|
|
if status.BoostOfID == "" {
|
|
return status, nil
|
|
}
|
|
return p.GetVisibleTargetStatus(ctx,
|
|
requester,
|
|
status.BoostOfID,
|
|
nil,
|
|
)
|
|
}
|
|
|
|
// GetAPIStatus fetches the appropriate API status model for target.
|
|
func (p *Processor) GetAPIStatus(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
target *gtsmodel.Status,
|
|
) (
|
|
apiStatus *apimodel.Status,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
apiStatus, err := p.converter.StatusToAPIStatus(ctx, target, requester, statusfilter.FilterContextNone, nil, nil)
|
|
if err != nil {
|
|
err = gtserror.Newf("error converting status: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
return apiStatus, nil
|
|
}
|
|
|
|
// InvalidateTimelinedStatus is a shortcut function for invalidating the cached
|
|
// representation one status in the home timeline and all list timelines of the
|
|
// given accountID. It should only be called in cases where a status update
|
|
// does *not* need to be passed into the processor via the worker queue, since
|
|
// such invalidation will, in that case, be handled by the processor instead.
|
|
func (p *Processor) InvalidateTimelinedStatus(ctx context.Context, accountID string, statusID string) error {
|
|
// Get lists first + bail if this fails.
|
|
lists, err := p.state.DB.GetListsByAccountID(ctx, accountID)
|
|
if err != nil {
|
|
return gtserror.Newf("db error getting lists for account %s: %w", accountID, err)
|
|
}
|
|
|
|
// Start new log entry with
|
|
// the above calling func's name.
|
|
l := log.
|
|
WithContext(ctx).
|
|
WithField("caller", log.Caller(3)).
|
|
WithField("accountID", accountID).
|
|
WithField("statusID", statusID)
|
|
|
|
// Unprepare item from home + list timelines, just log
|
|
// if something goes wrong since this is not a showstopper.
|
|
|
|
if err := p.state.Timelines.Home.UnprepareItem(ctx, accountID, statusID); err != nil {
|
|
l.Errorf("error unpreparing item from home timeline: %v", err)
|
|
}
|
|
|
|
for _, list := range lists {
|
|
if err := p.state.Timelines.List.UnprepareItem(ctx, list.ID, statusID); err != nil {
|
|
l.Errorf("error unpreparing item from list timeline %s: %v", list.ID, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|