mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-12-23 10:42:12 +00:00
67e11a1a61
* some small code fixups and changes * add check in ResolveIncomingActivity for transient activity types (i.e. activity ID is nil) * update test to handle new transient behaviour
194 lines
5.8 KiB
Go
194 lines
5.8 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package ap
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"sync"
|
|
|
|
"github.com/superseriousbusiness/activity/pub"
|
|
"github.com/superseriousbusiness/activity/streams"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
|
)
|
|
|
|
// mapPool is a memory pool of maps for JSON decoding.
|
|
var mapPool = sync.Pool{
|
|
New: func() any {
|
|
return make(map[string]any)
|
|
},
|
|
}
|
|
|
|
// getMap acquires a map from memory pool.
|
|
func getMap() map[string]any {
|
|
m := mapPool.Get().(map[string]any) //nolint
|
|
return m
|
|
}
|
|
|
|
// putMap clears and places map back in pool.
|
|
func putMap(m map[string]any) {
|
|
if len(m) > int(^uint8(0)) {
|
|
// don't pool overly
|
|
// large maps.
|
|
return
|
|
}
|
|
for k := range m {
|
|
delete(m, k)
|
|
}
|
|
mapPool.Put(m)
|
|
}
|
|
|
|
// ResolveActivity is a util function for pulling a pub.Activity type out of an incoming request body,
|
|
// returning the resolved activity type, error and whether to accept activity (false = transient i.e. ignore).
|
|
func ResolveIncomingActivity(r *http.Request) (pub.Activity, bool, gtserror.WithCode) {
|
|
// Get "raw" map
|
|
// destination.
|
|
raw := getMap()
|
|
|
|
// Tidy up when done.
|
|
defer r.Body.Close()
|
|
|
|
// Decode the JSON body stream into "raw" map.
|
|
if err := json.NewDecoder(r.Body).Decode(&raw); err != nil {
|
|
err := gtserror.Newf("error decoding json: %w", err)
|
|
return nil, false, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
// Resolve "raw" JSON to vocab.Type.
|
|
t, err := streams.ToType(r.Context(), raw)
|
|
if err != nil {
|
|
if !streams.IsUnmatchedErr(err) {
|
|
err := gtserror.Newf("error matching json to type: %w", err)
|
|
return nil, false, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
// Respond with bad request; we just couldn't
|
|
// match the type to one that we know about.
|
|
const text = "body json not resolvable as ActivityStreams type"
|
|
return nil, false, gtserror.NewErrorBadRequest(errors.New(text), text)
|
|
}
|
|
|
|
// Ensure this is an Activity type.
|
|
activity, ok := t.(pub.Activity)
|
|
if !ok {
|
|
text := fmt.Sprintf("cannot resolve vocab type %T as pub.Activity", t)
|
|
return nil, false, gtserror.NewErrorBadRequest(errors.New(text), text)
|
|
}
|
|
|
|
if activity.GetJSONLDId() == nil {
|
|
// missing ID indicates a transient ID as per:
|
|
//
|
|
// all objects distributed by the ActivityPub protocol MUST have unique global identifiers,
|
|
// unless they are intentionally transient (short lived activities that are not intended to
|
|
// be able to be looked up, such as some kinds of chat messages or game notifications).
|
|
return nil, false, nil
|
|
}
|
|
|
|
// Normalize any Statusable, Accountable, Pollable fields found.
|
|
// (see: https://github.com/superseriousbusiness/gotosocial/issues/1661)
|
|
NormalizeIncomingActivity(activity, raw)
|
|
|
|
// Release.
|
|
putMap(raw)
|
|
|
|
return activity, true, nil
|
|
}
|
|
|
|
// ResolveStatusable tries to resolve the given bytes into an ActivityPub Statusable representation.
|
|
// It will then perform normalization on the Statusable.
|
|
//
|
|
// Works for: Article, Document, Image, Video, Note, Page, Event, Place, Profile, Question.
|
|
func ResolveStatusable(ctx context.Context, b []byte) (Statusable, error) {
|
|
// Get "raw" map
|
|
// destination.
|
|
raw := getMap()
|
|
|
|
// Unmarshal the raw JSON data in a "raw" JSON map.
|
|
if err := json.Unmarshal(b, &raw); err != nil {
|
|
return nil, gtserror.Newf("error unmarshalling bytes into json: %w", err)
|
|
}
|
|
|
|
// Resolve an ActivityStreams type from JSON.
|
|
t, err := streams.ToType(ctx, raw)
|
|
if err != nil {
|
|
return nil, gtserror.Newf("error resolving json into ap vocab type: %w", err)
|
|
}
|
|
|
|
// Attempt to cast as Statusable.
|
|
statusable, ok := ToStatusable(t)
|
|
if !ok {
|
|
err := gtserror.Newf("cannot resolve vocab type %T as statusable", t)
|
|
return nil, gtserror.SetWrongType(err)
|
|
}
|
|
|
|
if pollable, ok := ToPollable(statusable); ok {
|
|
// Question requires extra normalization, and
|
|
// fortunately directly implements Statusable.
|
|
NormalizeIncomingPollOptions(pollable, raw)
|
|
statusable = pollable
|
|
}
|
|
|
|
NormalizeIncomingContent(statusable, raw)
|
|
NormalizeIncomingAttachments(statusable, raw)
|
|
NormalizeIncomingSummary(statusable, raw)
|
|
NormalizeIncomingName(statusable, raw)
|
|
|
|
// Release.
|
|
putMap(raw)
|
|
|
|
return statusable, nil
|
|
}
|
|
|
|
// ResolveStatusable tries to resolve the given bytes into an ActivityPub Accountable representation.
|
|
// It will then perform normalization on the Accountable.
|
|
//
|
|
// Works for: Application, Group, Organization, Person, Service
|
|
func ResolveAccountable(ctx context.Context, b []byte) (Accountable, error) {
|
|
// Get "raw" map
|
|
// destination.
|
|
raw := getMap()
|
|
|
|
// Unmarshal the raw JSON data in a "raw" JSON map.
|
|
if err := json.Unmarshal(b, &raw); err != nil {
|
|
return nil, gtserror.Newf("error unmarshalling bytes into json: %w", err)
|
|
}
|
|
|
|
// Resolve an ActivityStreams type from JSON.
|
|
t, err := streams.ToType(ctx, raw)
|
|
if err != nil {
|
|
return nil, gtserror.Newf("error resolving json into ap vocab type: %w", err)
|
|
}
|
|
|
|
// Attempt to cast as Statusable.
|
|
accountable, ok := ToAccountable(t)
|
|
if !ok {
|
|
err := gtserror.Newf("cannot resolve vocab type %T as accountable", t)
|
|
return nil, gtserror.SetWrongType(err)
|
|
}
|
|
|
|
NormalizeIncomingSummary(accountable, raw)
|
|
|
|
// Release.
|
|
putMap(raw)
|
|
|
|
return accountable, nil
|
|
}
|