mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-12-30 19:16:31 +00:00
de6e3e5f2a
* refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim <grufwub@gmail.com> Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
168 lines
6.3 KiB
Go
168 lines
6.3 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package status
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/ap"
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/id"
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
"github.com/superseriousbusiness/gotosocial/internal/messages"
|
|
"github.com/superseriousbusiness/gotosocial/internal/uris"
|
|
)
|
|
|
|
// FaveCreate adds a fave for the requestingAccount, targeting the given status (no-op if fave already exists).
|
|
func (p *Processor) FaveCreate(ctx context.Context, requestingAccount *gtsmodel.Account, targetStatusID string) (*apimodel.Status, gtserror.WithCode) {
|
|
targetStatus, existingFave, errWithCode := p.getFaveTarget(ctx, requestingAccount, targetStatusID)
|
|
if errWithCode != nil {
|
|
return nil, errWithCode
|
|
}
|
|
|
|
if existingFave != nil {
|
|
// Status is already faveed.
|
|
return p.apiStatus(ctx, targetStatus, requestingAccount)
|
|
}
|
|
|
|
// Create and store a new fave
|
|
faveID := id.NewULID()
|
|
gtsFave := >smodel.StatusFave{
|
|
ID: faveID,
|
|
AccountID: requestingAccount.ID,
|
|
Account: requestingAccount,
|
|
TargetAccountID: targetStatus.AccountID,
|
|
TargetAccount: targetStatus.Account,
|
|
StatusID: targetStatus.ID,
|
|
Status: targetStatus,
|
|
URI: uris.GenerateURIForLike(requestingAccount.Username, faveID),
|
|
}
|
|
|
|
if err := p.state.DB.PutStatusFave(ctx, gtsFave); err != nil {
|
|
err = fmt.Errorf("FaveCreate: error putting fave in database: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
// Process new status fave side effects.
|
|
p.state.Workers.EnqueueClientAPI(ctx, messages.FromClientAPI{
|
|
APObjectType: ap.ActivityLike,
|
|
APActivityType: ap.ActivityCreate,
|
|
GTSModel: gtsFave,
|
|
OriginAccount: requestingAccount,
|
|
TargetAccount: targetStatus.Account,
|
|
})
|
|
|
|
return p.apiStatus(ctx, targetStatus, requestingAccount)
|
|
}
|
|
|
|
// FaveRemove removes a fave for the requesting account, targeting the given status (no-op if fave doesn't exist).
|
|
func (p *Processor) FaveRemove(ctx context.Context, requestingAccount *gtsmodel.Account, targetStatusID string) (*apimodel.Status, gtserror.WithCode) {
|
|
targetStatus, existingFave, errWithCode := p.getFaveTarget(ctx, requestingAccount, targetStatusID)
|
|
if errWithCode != nil {
|
|
return nil, errWithCode
|
|
}
|
|
|
|
if existingFave == nil {
|
|
// Status isn't faveed.
|
|
return p.apiStatus(ctx, targetStatus, requestingAccount)
|
|
}
|
|
|
|
// We have a fave to remove.
|
|
if err := p.state.DB.DeleteStatusFaveByID(ctx, existingFave.ID); err != nil {
|
|
err = fmt.Errorf("FaveRemove: error removing status fave: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
// Process remove status fave side effects.
|
|
p.state.Workers.EnqueueClientAPI(ctx, messages.FromClientAPI{
|
|
APObjectType: ap.ActivityLike,
|
|
APActivityType: ap.ActivityUndo,
|
|
GTSModel: existingFave,
|
|
OriginAccount: requestingAccount,
|
|
TargetAccount: targetStatus.Account,
|
|
})
|
|
|
|
return p.apiStatus(ctx, targetStatus, requestingAccount)
|
|
}
|
|
|
|
// FavedBy returns a slice of accounts that have liked the given status, filtered according to privacy settings.
|
|
func (p *Processor) FavedBy(ctx context.Context, requestingAccount *gtsmodel.Account, targetStatusID string) ([]*apimodel.Account, gtserror.WithCode) {
|
|
targetStatus, errWithCode := p.getVisibleStatus(ctx, requestingAccount, targetStatusID)
|
|
if errWithCode != nil {
|
|
return nil, errWithCode
|
|
}
|
|
|
|
statusFaves, err := p.state.DB.GetStatusFavesForStatus(ctx, targetStatus.ID)
|
|
if err != nil {
|
|
return nil, gtserror.NewErrorNotFound(fmt.Errorf("FavedBy: error seeing who faved status: %s", err))
|
|
}
|
|
|
|
// For each fave, ensure that we're only showing
|
|
// the requester accounts that they don't block,
|
|
// and which don't block them.
|
|
apiAccounts := make([]*apimodel.Account, 0, len(statusFaves))
|
|
for _, fave := range statusFaves {
|
|
if blocked, err := p.state.DB.IsEitherBlocked(ctx, requestingAccount.ID, fave.AccountID); err != nil {
|
|
err = fmt.Errorf("FavedBy: error checking blocks: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
} else if blocked {
|
|
continue
|
|
}
|
|
|
|
if fave.Account == nil {
|
|
// Account isn't set for some reason, just skip.
|
|
log.WithContext(ctx).WithField("fave", fave).Warn("fave had no associated account")
|
|
continue
|
|
}
|
|
|
|
apiAccount, err := p.tc.AccountToAPIAccountPublic(ctx, fave.Account)
|
|
if err != nil {
|
|
err = fmt.Errorf("FavedBy: error converting account %s to frontend representation: %w", fave.AccountID, err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
apiAccounts = append(apiAccounts, apiAccount)
|
|
}
|
|
|
|
return apiAccounts, nil
|
|
}
|
|
|
|
func (p *Processor) getFaveTarget(ctx context.Context, requestingAccount *gtsmodel.Account, targetStatusID string) (*gtsmodel.Status, *gtsmodel.StatusFave, gtserror.WithCode) {
|
|
targetStatus, errWithCode := p.getVisibleStatus(ctx, requestingAccount, targetStatusID)
|
|
if errWithCode != nil {
|
|
return nil, nil, errWithCode
|
|
}
|
|
|
|
if !*targetStatus.Likeable {
|
|
err := errors.New("status is not faveable")
|
|
return nil, nil, gtserror.NewErrorForbidden(err, err.Error())
|
|
}
|
|
|
|
fave, err := p.state.DB.GetStatusFave(ctx, requestingAccount.ID, targetStatusID)
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
err = fmt.Errorf("getFaveTarget: error checking existing fave: %w", err)
|
|
return nil, nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
return targetStatus, fave, nil
|
|
}
|