mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-11-26 13:46:39 +00:00
2063d01cdb
* add back removed ValidateRequest() before backoff-retry loop
Signed-off-by: kim <grufwub@gmail.com>
* include response body in error response log
Signed-off-by: kim <grufwub@gmail.com>
* improved error response body draining
Signed-off-by: kim <grufwub@gmail.com>
* add more code commenting
Signed-off-by: kim <grufwub@gmail.com>
* move new error response logic to gtserror, handle instead in transport.Transport{} impl
Signed-off-by: kim <grufwub@gmail.com>
* appease ye oh mighty linter
Signed-off-by: kim <grufwub@gmail.com>
* fix mockhttpclient not setting request in http response
Signed-off-by: kim <grufwub@gmail.com>
---------
Signed-off-by: kim <grufwub@gmail.com>
67 lines
2 KiB
Go
67 lines
2 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package gtserror
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
|
|
"codeberg.org/gruf/go-byteutil"
|
|
)
|
|
|
|
// NewResponseError crafts an error from provided HTTP response
|
|
// including the method, status and body (if any provided). This
|
|
// will also wrap the returned error using WithStatusCode().
|
|
func NewResponseError(rsp *http.Response) error {
|
|
var buf byteutil.Buffer
|
|
|
|
// Get URL string ahead of time.
|
|
urlStr := rsp.Request.URL.String()
|
|
|
|
// Alloc guesstimate of required buf size.
|
|
buf.Guarantee(0 +
|
|
len(rsp.Request.Method) +
|
|
12 + // request to
|
|
len(urlStr) +
|
|
17 + // failed: status="
|
|
len(rsp.Status) +
|
|
8 + // " body="
|
|
256 + // max body size
|
|
1, // "
|
|
)
|
|
|
|
// Build error message string without
|
|
// using "fmt", as chances are this will
|
|
// be used in a hot code path and we
|
|
// know all the incoming types involved.
|
|
_, _ = buf.WriteString(rsp.Request.Method)
|
|
_, _ = buf.WriteString(" request to ")
|
|
_, _ = buf.WriteString(urlStr)
|
|
_, _ = buf.WriteString(" failed: status=\"")
|
|
_, _ = buf.WriteString(rsp.Status)
|
|
_, _ = buf.WriteString("\" body=\"")
|
|
_, _ = buf.WriteString(drainBody(rsp.Body, 256))
|
|
_, _ = buf.WriteString("\"")
|
|
|
|
// Create new error from msg.
|
|
err := errors.New(buf.String())
|
|
|
|
// Wrap error to provide status code.
|
|
return WithStatusCode(err, rsp.StatusCode)
|
|
}
|