mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-11-23 20:26:39 +00:00
fd6637df4a
* fix possible infinite recursion if moved accounts are self-referential * adds a defensive check for a boost being a boost of a boost wrapper * add checks on input for a boost of a boost * remove unnecessary check * add protections on account move to prevent move recursion loops * separate status conversion without boost logic into separate function to remove risk of recursion * move boost check to boost function itself * formatting * use error 422 instead of 500 * use gtserror not standard errors package for error creation
170 lines
4.9 KiB
Go
170 lines
4.9 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package account_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/oauth"
|
|
)
|
|
|
|
type MoveTestSuite struct {
|
|
AccountStandardTestSuite
|
|
}
|
|
|
|
func (suite *MoveTestSuite) TestMoveAccountOK() {
|
|
ctx := context.Background()
|
|
|
|
// Copy zork.
|
|
requestingAcct := new(gtsmodel.Account)
|
|
*requestingAcct = *suite.testAccounts["local_account_1"]
|
|
|
|
// Copy admin.
|
|
targetAcct := new(gtsmodel.Account)
|
|
*targetAcct = *suite.testAccounts["admin_account"]
|
|
|
|
// Update admin to alias back to zork.
|
|
targetAcct.AlsoKnownAsURIs = []string{requestingAcct.URI}
|
|
if err := suite.state.DB.UpdateAccount(
|
|
ctx,
|
|
targetAcct,
|
|
"also_known_as_uris",
|
|
); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Trigger move from zork to admin.
|
|
if err := suite.accountProcessor.MoveSelf(
|
|
ctx,
|
|
&oauth.Auth{
|
|
Token: oauth.DBTokenToToken(suite.testTokens["local_account_1"]),
|
|
Application: suite.testApplications["local_account_1"],
|
|
User: suite.testUsers["local_account_1"],
|
|
Account: requestingAcct,
|
|
},
|
|
&apimodel.AccountMoveRequest{
|
|
Password: "password",
|
|
MovedToURI: targetAcct.URI,
|
|
},
|
|
); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// There should be a message going to the worker.
|
|
cMsg, _ := suite.getClientMsg(5 * time.Second)
|
|
move, ok := cMsg.GTSModel.(*gtsmodel.Move)
|
|
if !ok {
|
|
suite.FailNow("", "could not cast %T to *gtsmodel.Move", move)
|
|
}
|
|
now := time.Now()
|
|
suite.WithinDuration(now, move.CreatedAt, 5*time.Second)
|
|
suite.WithinDuration(now, move.UpdatedAt, 5*time.Second)
|
|
suite.WithinDuration(now, move.AttemptedAt, 5*time.Second)
|
|
suite.Zero(move.SucceededAt)
|
|
suite.NotZero(move.ID)
|
|
suite.Equal(requestingAcct.URI, move.OriginURI)
|
|
suite.NotNil(move.Origin)
|
|
suite.Equal(targetAcct.URI, move.TargetURI)
|
|
suite.NotNil(move.Target)
|
|
suite.NotZero(move.URI)
|
|
|
|
// Move should be in the database now.
|
|
move, err := suite.state.DB.GetMoveByOriginTarget(
|
|
ctx,
|
|
requestingAcct.URI,
|
|
targetAcct.URI,
|
|
)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
suite.NotNil(move)
|
|
|
|
// Origin account should have move ID and move to URI set.
|
|
suite.Equal(move.ID, requestingAcct.MoveID)
|
|
suite.Equal(targetAcct.URI, requestingAcct.MovedToURI)
|
|
}
|
|
|
|
func (suite *MoveTestSuite) TestMoveAccountNotAliased() {
|
|
ctx := context.Background()
|
|
|
|
// Copy zork.
|
|
requestingAcct := new(gtsmodel.Account)
|
|
*requestingAcct = *suite.testAccounts["local_account_1"]
|
|
|
|
// Don't copy admin.
|
|
targetAcct := suite.testAccounts["admin_account"]
|
|
|
|
// Trigger move from zork to admin.
|
|
//
|
|
// Move should fail since admin is
|
|
// not aliased back to zork.
|
|
err := suite.accountProcessor.MoveSelf(
|
|
ctx,
|
|
&oauth.Auth{
|
|
Token: oauth.DBTokenToToken(suite.testTokens["local_account_1"]),
|
|
Application: suite.testApplications["local_account_1"],
|
|
User: suite.testUsers["local_account_1"],
|
|
Account: requestingAcct,
|
|
},
|
|
&apimodel.AccountMoveRequest{
|
|
Password: "password",
|
|
MovedToURI: targetAcct.URI,
|
|
},
|
|
)
|
|
suite.EqualError(err, "target account http://localhost:8080/users/admin is not aliased to this account via alsoKnownAs; if you just changed it, please wait a few minutes and try the Move again")
|
|
}
|
|
|
|
func (suite *MoveTestSuite) TestMoveAccountBadPassword() {
|
|
ctx := context.Background()
|
|
|
|
// Copy zork.
|
|
requestingAcct := new(gtsmodel.Account)
|
|
*requestingAcct = *suite.testAccounts["local_account_1"]
|
|
|
|
// Don't copy admin.
|
|
targetAcct := suite.testAccounts["admin_account"]
|
|
|
|
// Trigger move from zork to admin.
|
|
//
|
|
// Move should fail since admin is
|
|
// not aliased back to zork.
|
|
err := suite.accountProcessor.MoveSelf(
|
|
ctx,
|
|
&oauth.Auth{
|
|
Token: oauth.DBTokenToToken(suite.testTokens["local_account_1"]),
|
|
Application: suite.testApplications["local_account_1"],
|
|
User: suite.testUsers["local_account_1"],
|
|
Account: requestingAcct,
|
|
},
|
|
&apimodel.AccountMoveRequest{
|
|
Password: "boobies",
|
|
MovedToURI: targetAcct.URI,
|
|
},
|
|
)
|
|
suite.EqualError(err, "invalid password provided in Move request")
|
|
}
|
|
|
|
func TestMoveTestSuite(t *testing.T) {
|
|
suite.Run(t, new(MoveTestSuite))
|
|
}
|