mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-12-28 01:56:30 +00:00
223025fc27
* cache transports in controller by privkey-generated pubkey, add retry logic to transport requests Signed-off-by: kim <grufwub@gmail.com> * update code comments, defer mutex unlocks Signed-off-by: kim <grufwub@gmail.com> * add count to 'performing request' log message Signed-off-by: kim <grufwub@gmail.com> * reduce repeated conversions of same url.URL object Signed-off-by: kim <grufwub@gmail.com> * move worker.Worker to concurrency subpackage, add WorkQueue type, limit transport http client use by WorkQueue Signed-off-by: kim <grufwub@gmail.com> * fix security advisories regarding max outgoing conns, max rsp body size - implemented by a new httpclient.Client{} that wraps an underlying client with a queue to limit connections, and limit reader wrapping a response body with a configured maximum size - update pub.HttpClient args passed around to be this new httpclient.Client{} Signed-off-by: kim <grufwub@gmail.com> * add httpclient tests, move ip validation to separate package + change mechanism Signed-off-by: kim <grufwub@gmail.com> * fix merge conflicts Signed-off-by: kim <grufwub@gmail.com> * use singular mutex in transport rather than separate signer mus Signed-off-by: kim <grufwub@gmail.com> * improved useragent string Signed-off-by: kim <grufwub@gmail.com> * add note regarding missing test Signed-off-by: kim <grufwub@gmail.com> * remove useragent field from transport (instead store in controller) Signed-off-by: kim <grufwub@gmail.com> * shutup linter Signed-off-by: kim <grufwub@gmail.com> * reset other signing headers on each loop iteration Signed-off-by: kim <grufwub@gmail.com> * respect request ctx during retry-backoff sleep period Signed-off-by: kim <grufwub@gmail.com> * use external pkg with docs explaining performance "hack" Signed-off-by: kim <grufwub@gmail.com> * use http package constants instead of string method literals Signed-off-by: kim <grufwub@gmail.com> * add license file headers Signed-off-by: kim <grufwub@gmail.com> * update code comment to match new func names Signed-off-by: kim <grufwub@gmail.com> * updates to user-agent string Signed-off-by: kim <grufwub@gmail.com> * update signed testrig models to fit with new transport logic (instead uses separate signer now) Signed-off-by: kim <grufwub@gmail.com> * fuck you linter Signed-off-by: kim <grufwub@gmail.com>
123 lines
5.2 KiB
Go
123 lines
5.2 KiB
Go
/*
|
|
GoToSocial
|
|
Copyright (C) 2021-2022 GoToSocial Authors admin@gotosocial.org
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU Affero General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU Affero General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Affero General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
package federation_test
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/go-fed/httpsig"
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/activity/pub"
|
|
"github.com/superseriousbusiness/gotosocial/internal/ap"
|
|
"github.com/superseriousbusiness/gotosocial/internal/concurrency"
|
|
"github.com/superseriousbusiness/gotosocial/internal/federation"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/messages"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
)
|
|
|
|
type FederatingProtocolTestSuite struct {
|
|
FederatorStandardTestSuite
|
|
}
|
|
|
|
// make sure PostInboxRequestBodyHook properly sets the inbox username and activity on the context
|
|
func (suite *FederatingProtocolTestSuite) TestPostInboxRequestBodyHook() {
|
|
// the activity we're gonna use
|
|
activity := suite.testActivities["dm_for_zork"]
|
|
|
|
fedWorker := concurrency.NewWorkerPool[messages.FromFederator](-1, -1)
|
|
|
|
// setup transport controller with a no-op client so we don't make external calls
|
|
tc := testrig.NewTestTransportController(testrig.NewMockHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
return nil, nil
|
|
}), suite.db, fedWorker)
|
|
// setup module being tested
|
|
federator := federation.NewFederator(suite.db, testrig.NewTestFederatingDB(suite.db, fedWorker), tc, suite.tc, testrig.NewTestMediaManager(suite.db, suite.storage))
|
|
|
|
// setup request
|
|
ctx := context.Background()
|
|
request := httptest.NewRequest(http.MethodPost, "http://localhost:8080/users/the_mighty_zork/inbox", nil) // the endpoint we're hitting
|
|
request.Header.Set("Signature", activity.SignatureHeader)
|
|
|
|
// trigger the function being tested, and return the new context it creates
|
|
newContext, err := federator.PostInboxRequestBodyHook(ctx, request, activity.Activity)
|
|
suite.NoError(err)
|
|
suite.NotNil(newContext)
|
|
|
|
// activity should be set on context now
|
|
activityI := newContext.Value(ap.ContextActivity)
|
|
suite.NotNil(activityI)
|
|
returnedActivity, ok := activityI.(pub.Activity)
|
|
suite.True(ok)
|
|
suite.NotNil(returnedActivity)
|
|
suite.EqualValues(activity.Activity, returnedActivity)
|
|
}
|
|
|
|
func (suite *FederatingProtocolTestSuite) TestAuthenticatePostInbox() {
|
|
// the activity we're gonna use
|
|
activity := suite.testActivities["dm_for_zork"]
|
|
sendingAccount := suite.testAccounts["remote_account_1"]
|
|
inboxAccount := suite.testAccounts["local_account_1"]
|
|
|
|
fedWorker := concurrency.NewWorkerPool[messages.FromFederator](-1, -1)
|
|
|
|
tc := testrig.NewTestTransportController(testrig.NewMockHTTPClient(nil), suite.db, fedWorker)
|
|
// now setup module being tested, with the mock transport controller
|
|
federator := federation.NewFederator(suite.db, testrig.NewTestFederatingDB(suite.db, fedWorker), tc, suite.tc, testrig.NewTestMediaManager(suite.db, suite.storage))
|
|
|
|
request := httptest.NewRequest(http.MethodPost, "http://localhost:8080/users/the_mighty_zork/inbox", nil)
|
|
// we need these headers for the request to be validated
|
|
request.Header.Set("Signature", activity.SignatureHeader)
|
|
request.Header.Set("Date", activity.DateHeader)
|
|
request.Header.Set("Digest", activity.DigestHeader)
|
|
|
|
verifier, err := httpsig.NewVerifier(request)
|
|
suite.NoError(err)
|
|
|
|
ctx := context.Background()
|
|
// by the time AuthenticatePostInbox is called, PostInboxRequestBodyHook should have already been called,
|
|
// which should have set the account and username onto the request. We can replicate that behavior here:
|
|
ctxWithAccount := context.WithValue(ctx, ap.ContextReceivingAccount, inboxAccount)
|
|
ctxWithActivity := context.WithValue(ctxWithAccount, ap.ContextActivity, activity)
|
|
ctxWithVerifier := context.WithValue(ctxWithActivity, ap.ContextRequestingPublicKeyVerifier, verifier)
|
|
ctxWithSignature := context.WithValue(ctxWithVerifier, ap.ContextRequestingPublicKeySignature, activity.SignatureHeader)
|
|
|
|
// we can pass this recorder as a writer and read it back after
|
|
recorder := httptest.NewRecorder()
|
|
|
|
// trigger the function being tested, and return the new context it creates
|
|
newContext, authed, err := federator.AuthenticatePostInbox(ctxWithSignature, recorder, request)
|
|
suite.NoError(err)
|
|
suite.True(authed)
|
|
|
|
// since we know this account already it should be set on the context
|
|
requestingAccountI := newContext.Value(ap.ContextRequestingAccount)
|
|
suite.NotNil(requestingAccountI)
|
|
requestingAccount, ok := requestingAccountI.(*gtsmodel.Account)
|
|
suite.True(ok)
|
|
suite.Equal(sendingAccount.Username, requestingAccount.Username)
|
|
}
|
|
|
|
func TestFederatingProtocolTestSuite(t *testing.T) {
|
|
suite.Run(t, new(FederatingProtocolTestSuite))
|
|
}
|