mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-12-01 16:12:45 +00:00
de6e3e5f2a
* refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim <grufwub@gmail.com> Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
212 lines
6.5 KiB
Go
212 lines
6.5 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package bundb_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/id"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
)
|
|
|
|
func (suite *NotificationTestSuite) spamNotifs() {
|
|
// spam a shit ton of notifs into the database
|
|
// half of them will be for zork, the other half
|
|
// will be for random accounts
|
|
notifCount := 10000
|
|
|
|
zork := suite.testAccounts["local_account_1"]
|
|
|
|
for i := 0; i < notifCount; i++ {
|
|
notifID := id.NewULID()
|
|
|
|
var targetAccountID string
|
|
if i%2 == 0 {
|
|
targetAccountID = zork.ID
|
|
} else {
|
|
randomAssID, err := id.NewRandomULID()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
targetAccountID = randomAssID
|
|
}
|
|
|
|
statusID, err := id.NewRandomULID()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
originAccountID, err := id.NewRandomULID()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
notif := >smodel.Notification{
|
|
ID: notifID,
|
|
NotificationType: gtsmodel.NotificationFave,
|
|
CreatedAt: time.Now(),
|
|
TargetAccountID: targetAccountID,
|
|
OriginAccountID: originAccountID,
|
|
StatusID: statusID,
|
|
Read: testrig.FalseBool(),
|
|
}
|
|
|
|
if err := suite.db.Put(context.Background(), notif); err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
|
|
fmt.Printf("\n\n\nput %d notifs in the db\n\n\n", notifCount)
|
|
}
|
|
|
|
type NotificationTestSuite struct {
|
|
BunDBStandardTestSuite
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestGetAccountNotificationsWithSpam() {
|
|
suite.spamNotifs()
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
before := time.Now()
|
|
notifications, err := suite.db.GetAccountNotifications(context.Background(), testAccount.ID, []string{}, 20, id.Highest, id.Lowest)
|
|
suite.NoError(err)
|
|
timeTaken := time.Since(before)
|
|
fmt.Printf("\n\n\n withSpam: got %d notifications in %s\n\n\n", len(notifications), timeTaken)
|
|
|
|
suite.NotNil(notifications)
|
|
for _, n := range notifications {
|
|
suite.Equal(testAccount.ID, n.TargetAccountID)
|
|
}
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestGetAccountNotificationsWithoutSpam() {
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
before := time.Now()
|
|
notifications, err := suite.db.GetAccountNotifications(context.Background(), testAccount.ID, []string{}, 20, id.Highest, id.Lowest)
|
|
suite.NoError(err)
|
|
timeTaken := time.Since(before)
|
|
fmt.Printf("\n\n\n withoutSpam: got %d notifications in %s\n\n\n", len(notifications), timeTaken)
|
|
|
|
suite.NotNil(notifications)
|
|
for _, n := range notifications {
|
|
suite.Equal(testAccount.ID, n.TargetAccountID)
|
|
}
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestDeleteNotificationsWithSpam() {
|
|
suite.spamNotifs()
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
err := suite.db.DeleteNotifications(context.Background(), nil, testAccount.ID, "")
|
|
suite.NoError(err)
|
|
|
|
notifications, err := suite.db.GetAccountNotifications(context.Background(), testAccount.ID, []string{}, 20, id.Highest, id.Lowest)
|
|
suite.NoError(err)
|
|
suite.NotNil(notifications)
|
|
suite.Empty(notifications)
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestDeleteNotificationsWithTwoAccounts() {
|
|
suite.spamNotifs()
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
err := suite.db.DeleteNotifications(context.Background(), nil, testAccount.ID, "")
|
|
suite.NoError(err)
|
|
|
|
notifications, err := suite.db.GetAccountNotifications(context.Background(), testAccount.ID, []string{}, 20, id.Highest, id.Lowest)
|
|
suite.NoError(err)
|
|
suite.NotNil(notifications)
|
|
suite.Empty(notifications)
|
|
|
|
notif := []*gtsmodel.Notification{}
|
|
err = suite.db.GetAll(context.Background(), ¬if)
|
|
suite.NoError(err)
|
|
suite.NotEmpty(notif)
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestDeleteNotificationsOriginatingFromAccount() {
|
|
testAccount := suite.testAccounts["local_account_2"]
|
|
|
|
if err := suite.db.DeleteNotifications(context.Background(), nil, "", testAccount.ID); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
notif := []*gtsmodel.Notification{}
|
|
if err := suite.db.GetAll(context.Background(), ¬if); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
for _, n := range notif {
|
|
if n.OriginAccountID == testAccount.ID {
|
|
suite.FailNowf("", "no notifications with origin account id %s should remain", testAccount.ID)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestDeleteNotificationsOriginatingFromAndTargetingAccount() {
|
|
originAccount := suite.testAccounts["local_account_2"]
|
|
targetAccount := suite.testAccounts["admin_account"]
|
|
|
|
if err := suite.db.DeleteNotifications(context.Background(), nil, targetAccount.ID, originAccount.ID); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
notif := []*gtsmodel.Notification{}
|
|
if err := suite.db.GetAll(context.Background(), ¬if); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
for _, n := range notif {
|
|
if n.OriginAccountID == originAccount.ID || n.TargetAccountID == targetAccount.ID {
|
|
suite.FailNowf(
|
|
"",
|
|
"no notifications with origin account id %s and target account %s should remain",
|
|
originAccount.ID,
|
|
targetAccount.ID,
|
|
)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (suite *NotificationTestSuite) TestDeleteNotificationsPertainingToStatusID() {
|
|
testStatus := suite.testStatuses["local_account_1_status_1"]
|
|
|
|
if err := suite.db.DeleteNotificationsForStatus(context.Background(), testStatus.ID); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
notif := []*gtsmodel.Notification{}
|
|
if err := suite.db.GetAll(context.Background(), ¬if); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
for _, n := range notif {
|
|
if n.StatusID == testStatus.ID {
|
|
suite.FailNowf("", "no notifications with status id %s should remain", testStatus.ID)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestNotificationTestSuite(t *testing.T) {
|
|
suite.Run(t, new(NotificationTestSuite))
|
|
}
|