From 300f73331a22f231dd8b410e376699e417971b74 Mon Sep 17 00:00:00 2001
From: Henry Jameson <me@hjkos.com>
Date: Mon, 23 Dec 2024 04:38:43 +0200
Subject: [PATCH] more warnings fixed

---
 src/components/account_actions/account_actions.vue   |  2 ++
 .../bookmark_folder_edit/bookmark_folder_edit.vue    |  2 ++
 .../extra_notifications/extra_notifications.vue      |  1 +
 src/components/follow_button/follow_button.vue       |  1 +
 src/components/font_control/font_control.vue         | 12 +++++-------
 src/components/gallery/gallery.vue                   |  1 -
 src/components/lists_edit/lists_edit.vue             |  2 ++
 src/components/palette_editor/palette_editor.vue     |  1 +
 .../settings_modal/admin_tabs/frontends_tab.vue      | 12 ++++++++++--
 .../settings_modal/admin_tabs/limits_tab.js          |  1 -
 .../settings_modal/helpers/attachment_setting.vue    |  4 ----
 src/components/settings_modal/settings_modal.vue     |  5 ++++-
 .../tabs/security_tab/security_tab.vue               |  2 ++
 .../settings_modal/tabs/style_tab/style_tab.vue      |  8 +++++++-
 .../tabs/style_tab/virtual_directives_tab.vue        |  1 +
 src/components/status/status.vue                     |  5 ++++-
 16 files changed, 42 insertions(+), 18 deletions(-)

diff --git a/src/components/account_actions/account_actions.vue b/src/components/account_actions/account_actions.vue
index 9a7c6824..62862a8f 100644
--- a/src/components/account_actions/account_actions.vue
+++ b/src/components/account_actions/account_actions.vue
@@ -86,6 +86,7 @@
         <i18n-t
           keypath="user_card.block_confirm"
           tag="span"
+          scope="global"
         >
           <template #user>
             <span
@@ -107,6 +108,7 @@
         <i18n-t
           keypath="user_card.remove_follower_confirm"
           tag="span"
+          scope="global"
         >
           <template #user>
             <span
diff --git a/src/components/bookmark_folder_edit/bookmark_folder_edit.vue b/src/components/bookmark_folder_edit/bookmark_folder_edit.vue
index 709df402..4a5bff49 100644
--- a/src/components/bookmark_folder_edit/bookmark_folder_edit.vue
+++ b/src/components/bookmark_folder_edit/bookmark_folder_edit.vue
@@ -17,6 +17,7 @@
         <i18n-t
           v-if="id"
           keypath="bookmark_folders.editing_folder"
+          scope="global"
         >
           <template #folderName>
             {{ name }}
@@ -25,6 +26,7 @@
         <i18n-t
           v-else
           keypath="bookmark_folders.creating_folder"
+          scope="global"
         />
       </h1>
     </div>
diff --git a/src/components/extra_notifications/extra_notifications.vue b/src/components/extra_notifications/extra_notifications.vue
index 600c99bb..ffbb43eb 100644
--- a/src/components/extra_notifications/extra_notifications.vue
+++ b/src/components/extra_notifications/extra_notifications.vue
@@ -56,6 +56,7 @@
       tag="span"
       class="notification tip extra-notification"
       keypath="notifications.configuration_tip"
+      scope="global"
     >
       <template #theSettings>
         <button
diff --git a/src/components/follow_button/follow_button.vue b/src/components/follow_button/follow_button.vue
index e421c15b..3606b68b 100644
--- a/src/components/follow_button/follow_button.vue
+++ b/src/components/follow_button/follow_button.vue
@@ -17,6 +17,7 @@
         @cancelled="hideConfirmUnfollow"
       >
         <i18n-t
+          scope="global"
           keypath="user_card.unfollow_confirm"
           tag="span"
         >
diff --git a/src/components/font_control/font_control.vue b/src/components/font_control/font_control.vue
index cda7b6f1..644efc20 100644
--- a/src/components/font_control/font_control.vue
+++ b/src/components/font_control/font_control.vue
@@ -1,11 +1,8 @@
 <template>
-  <div
-    class="font-control"
-    :class="{ custom: isCustom }"
-  >
+  <div class="font-control">
     <label
       :id="name + '-label'"
-      :for="preset === 'custom' ? name : name + '-font-switcher'"
+      :for="manualEntry ? name : name + '-font-switcher'"
       class="label"
     >
       {{ label }}
@@ -23,12 +20,13 @@
       <label
         v-if="manualEntry"
         :id="name + '-label'"
-        :for="preset === 'custom' ? name : name + '-font-switcher'"
+        :for="manualEntry ? name : name + '-font-switcher'"
         class="label"
       >
         <i18n-t
           keypath="settings.style.themes3.font.entry"
           tag="span"
+          scope="global"
         >
           <template #fontFamily>
             <code>font-family</code>
@@ -38,7 +36,7 @@
       <label
         v-else
         :id="name + '-label'"
-        :for="preset === 'custom' ? name : name + '-font-switcher'"
+        :for="manualEntry ? name : name + '-font-switcher'"
         class="label"
       >
         {{ $t('settings.style.themes3.font.select') }}
diff --git a/src/components/gallery/gallery.vue b/src/components/gallery/gallery.vue
index 40048285..3e696216 100644
--- a/src/components/gallery/gallery.vue
+++ b/src/components/gallery/gallery.vue
@@ -32,7 +32,6 @@
             :description="descriptions && descriptions[attachment.id]"
             :hide-description="size === 'small' || tooManyAttachments && hidingLong"
             :style="itemStyle(attachment.id, row.items)"
-            @setMedia="onMedia"
             @naturalSizeLoad="onNaturalSizeLoad"
           />
         </div>
diff --git a/src/components/lists_edit/lists_edit.vue b/src/components/lists_edit/lists_edit.vue
index 3c2066f6..51adbdbf 100644
--- a/src/components/lists_edit/lists_edit.vue
+++ b/src/components/lists_edit/lists_edit.vue
@@ -17,6 +17,7 @@
         <i18n-t
           v-if="id"
           keypath="lists.editing_list"
+          scope="global"
         >
           <template #listTitle>
             {{ title }}
@@ -25,6 +26,7 @@
         <i18n-t
           v-else
           keypath="lists.creating_list"
+          scope="global"
         />
       </div>
     </div>
diff --git a/src/components/palette_editor/palette_editor.vue b/src/components/palette_editor/palette_editor.vue
index d88accf5..e5ae2000 100644
--- a/src/components/palette_editor/palette_editor.vue
+++ b/src/components/palette_editor/palette_editor.vue
@@ -6,6 +6,7 @@
     <ColorInput
       v-for="key in paletteKeys"
       :key="key"
+      :name="key"
       :model-value="props.modelValue[key]"
       :fallback="fallback(key)"
       :label="$t('settings.style.themes3.palette.' + key)"
diff --git a/src/components/settings_modal/admin_tabs/frontends_tab.vue b/src/components/settings_modal/admin_tabs/frontends_tab.vue
index 8fb3d399..591c0d1c 100644
--- a/src/components/settings_modal/admin_tabs/frontends_tab.vue
+++ b/src/components/settings_modal/admin_tabs/frontends_tab.vue
@@ -49,11 +49,13 @@
             <span v-if="adminDraft && adminDraft[':pleroma'][':frontends'][':primary']?.name === frontend.name">
               <i18n-t
                 v-if="adminDraft && adminDraft[':pleroma'][':frontends'][':primary']?.ref === frontend.refs[0]"
+                scope="global"
                 keypath="admin_dash.frontend.is_default"
               />
               <i18n-t
                 v-else
                 keypath="admin_dash.frontend.is_default_custom"
+                scope="global"
               >
                 <template #version>
                   <code>{{ adminDraft && adminDraft[':pleroma'][':frontends'][':primary'].ref }}</code>
@@ -120,7 +122,10 @@
                         @click.prevent="update(frontend, ref)"
                         @click="close"
                       >
-                        <i18n-t keypath="admin_dash.frontend.install_version">
+                        <i18n-t
+                          keypath="admin_dash.frontend.install_version"
+                          scope="global"
+                        >
                           <template #version>
                             <code>{{ ref }}</code>
                           </template>
@@ -177,7 +182,10 @@
                         @click.prevent="setDefault(frontend, ref)"
                         @click="close"
                       >
-                        <i18n-t keypath="admin_dash.frontend.set_default_version">
+                        <i18n-t
+                          keypath="admin_dash.frontend.set_default_version"
+                          scope="global"
+                        >
                           <template #version>
                             <code>{{ ref }}</code>
                           </template>
diff --git a/src/components/settings_modal/admin_tabs/limits_tab.js b/src/components/settings_modal/admin_tabs/limits_tab.js
index 684739c3..acf7d343 100644
--- a/src/components/settings_modal/admin_tabs/limits_tab.js
+++ b/src/components/settings_modal/admin_tabs/limits_tab.js
@@ -14,7 +14,6 @@ library.add(
 )
 
 const LimitsTab = {
-  data () {},
   components: {
     BooleanSetting,
     ChoiceSetting,
diff --git a/src/components/settings_modal/helpers/attachment_setting.vue b/src/components/settings_modal/helpers/attachment_setting.vue
index 96c80ab1..a61d56e8 100644
--- a/src/components/settings_modal/helpers/attachment_setting.vue
+++ b/src/components/settings_modal/helpers/attachment_setting.vue
@@ -48,18 +48,14 @@
         :attachment="attachment"
         size="small"
         hide-description
-        @setMedia="onMedia"
-        @naturalSizeLoad="onNaturalSizeLoad"
       />
       <div class="controls control-upload">
         <MediaUpload
           ref="mediaUpload"
           class="media-upload-icon"
-          :drop-files="dropFiles"
           normal-button
           :accept-types="acceptTypes"
           @uploaded="setMediaFile"
-          @upload-failed="uploadFailed"
         />
       </div>
     </div>
diff --git a/src/components/settings_modal/settings_modal.vue b/src/components/settings_modal/settings_modal.vue
index b9f7c355..8fa9667a 100644
--- a/src/components/settings_modal/settings_modal.vue
+++ b/src/components/settings_modal/settings_modal.vue
@@ -110,7 +110,10 @@
           {{ $t("settings.expert_mode") }}
         </Checkbox>
         <span v-if="modalMode === 'admin'">
-          <i18n-t keypath="admin_dash.wip_notice">
+          <i18n-t
+            scope="global"
+            keypath="admin_dash.wip_notice"
+          >
             <template #adminFeLink>
               <a
                 href="/pleroma/admin/#/login-pleroma"
diff --git a/src/components/settings_modal/tabs/security_tab/security_tab.vue b/src/components/settings_modal/tabs/security_tab/security_tab.vue
index 74103f6f..4431550a 100644
--- a/src/components/settings_modal/tabs/security_tab/security_tab.vue
+++ b/src/components/settings_modal/tabs/security_tab/security_tab.vue
@@ -149,6 +149,7 @@
       </div>
       <div>
         <i18n-t
+          scope="global"
           keypath="settings.new_alias_target"
           tag="p"
         >
@@ -184,6 +185,7 @@
         <i18n-t
           keypath="settings.move_account_target"
           tag="p"
+          scope="global"
         >
           <template #example>
             <code>
diff --git a/src/components/settings_modal/tabs/style_tab/style_tab.vue b/src/components/settings_modal/tabs/style_tab/style_tab.vue
index b023c69c..3cdb4183 100644
--- a/src/components/settings_modal/tabs/style_tab/style_tab.vue
+++ b/src/components/settings_modal/tabs/style_tab/style_tab.vue
@@ -186,6 +186,7 @@
           >
             <ColorInput
               v-model="editedBackgroundColor"
+              name="component-background-color"
               :fallback="computeColor(editedBackgroundColor) ?? previewColors.background"
               :disabled="!isBackgroundColorPresent"
               :label="$t('settings.style.themes3.editor.background')"
@@ -197,6 +198,7 @@
             <ColorInput
               v-if="componentHas('Text')"
               v-model="editedTextColor"
+              name="component-text-color"
               :fallback="computeColor(editedTextColor) ?? previewColors.text"
               :label="$t('settings.style.themes3.editor.text_color')"
               :disabled="!isTextColorPresent"
@@ -257,6 +259,7 @@
             <ColorInput
               v-if="componentHas('Link')"
               v-model="editedLinkColor"
+              name="component-link-color"
               :fallback="computeColor(editedLinkColor) ?? previewColors.link"
               :label="$t('settings.style.themes3.editor.link_color')"
               :disabled="!isLinkColorPresent"
@@ -271,6 +274,7 @@
             <ColorInput
               v-if="componentHas('Icon')"
               v-model="editedIconColor"
+              name="component-icon-color"
               :fallback="computeColor(editedIconColor) ?? previewColors.icon"
               :label="$t('settings.style.themes3.editor.icon_color')"
               :disabled="!isIconColorPresent"
@@ -285,6 +289,7 @@
             <ColorInput
               v-if="componentHas('Border')"
               v-model="editedBorderColor"
+              name="component-border-color"
               :fallback="computeColor(editedBorderColor) ?? previewColors.border"
               :label="$t('settings.style.themes3.editor.border_color')"
               :disabled="!isBorderColorPresent"
@@ -298,6 +303,7 @@
             </Tooltip>
             <OpacityInput
               v-model="editedOpacity"
+              name="component-opacity"
               :disabled="!isOpacityPresent"
               :label="$t('settings.style.themes3.editor.opacity')"
             />
@@ -306,6 +312,7 @@
             </Tooltip>
             <RoundnessInput
               v-model="editedRoundness"
+              name="component-roundness"
               :disabled="!isRoundnessPresent"
               :label="$t('settings.style.themes3.editor.roundness')"
             />
@@ -386,7 +393,6 @@
         key="variables"
         :label="$t('settings.style.themes3.editor.variables_tab')"
         :model-value="virtualDirectives"
-        :normalize-shadows="normalizeShadows"
         @update:modelValue="updateVirtualDirectives"
       />
     </tab-switcher>
diff --git a/src/components/settings_modal/tabs/style_tab/virtual_directives_tab.vue b/src/components/settings_modal/tabs/style_tab/virtual_directives_tab.vue
index 68648002..f151d3a8 100644
--- a/src/components/settings_modal/tabs/style_tab/virtual_directives_tab.vue
+++ b/src/components/settings_modal/tabs/style_tab/virtual_directives_tab.vue
@@ -72,6 +72,7 @@
         :compact="true"
       />
       <ColorInput
+        name="virtual-directive-color"
         v-if="selectedVirtualDirectiveValType === 'color'"
         v-model="draftVirtualDirective"
         :fallback="computeColor(draftVirtualDirective)"
diff --git a/src/components/status/status.vue b/src/components/status/status.vue
index 765acf32..56a4bddf 100644
--- a/src/components/status/status.vue
+++ b/src/components/status/status.vue
@@ -444,7 +444,10 @@
             v-else-if="hasInvisibleQuote"
             class="quoted-status -unavailable-prompt"
           >
-            <i18n-t keypath="status.invisible_quote">
+            <i18n-t
+              scope="global"
+              keypath="status.invisible_quote"
+            >
               <template #link>
                 <bdi>
                   <a