From 0dd343f2d40939900d12f8c42c5c7d4d6be97f63 Mon Sep 17 00:00:00 2001
From: Brian Underwood <public@brian-underwood.codes>
Date: Tue, 7 Feb 2023 21:48:57 +0100
Subject: [PATCH 1/2] Specs for the gallery component

---
 test/unit/specs/components/gallery.spec.js | 276 +++++++++++++++++++++
 1 file changed, 276 insertions(+)
 create mode 100644 test/unit/specs/components/gallery.spec.js

diff --git a/test/unit/specs/components/gallery.spec.js b/test/unit/specs/components/gallery.spec.js
new file mode 100644
index 00000000..108e2b6b
--- /dev/null
+++ b/test/unit/specs/components/gallery.spec.js
@@ -0,0 +1,276 @@
+import Gallery from 'src/components/gallery/gallery.vue'
+
+describe.only('Gallery', () => {
+  let local
+
+  it('attachments is falsey', () => {
+    local = { attachments: false }
+    expect(Gallery.computed.rows.call(local)).to.eql([])
+
+    local = { attachments: null }
+    expect(Gallery.computed.rows.call(local)).to.eql([])
+
+    local = { attachments: undefined }
+    expect(Gallery.computed.rows.call(local)).to.eql([])
+  })
+
+  it('no attachments', () => {
+    local = { attachments: [] }
+    expect(Gallery.computed.rows.call(local)).to.eql([])
+  })
+
+  it('one audio attachment', () => {
+    local = {
+      attachments: [
+        { mimetype: 'audio/mpeg' }
+      ]
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] }
+    ])
+  })
+
+  it('one image attachment', () => {
+    local = {
+      attachments: [
+        { mimetype: 'image/png' }
+      ]
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { items: [{ mimetype: 'image/png' }] }
+    ])
+  })
+
+  it('one audio attachment and one image attachment', () => {
+    local = {
+      attachments: [
+        { mimetype: 'audio/mpeg' },
+        { mimetype: 'image/png' }
+      ]
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/png' }] }
+    ])
+  })
+
+  it('has "size" key set to "hide"', () => {
+    let local
+    local = {
+      attachments: [
+        { mimetype: 'audio/mpeg' }
+      ],
+      size: 'hide'
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { minimal: true, items: [{ mimetype: 'audio/mpeg' }] }
+    ])
+
+    local = {
+      attachments: [
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'audio/mpeg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'audio/mpeg' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' }
+      ],
+      size: 'hide'
+    }
+
+    // When defining `size: hide`, the `items` aren't
+    // grouped and `audio` isn't set
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { minimal: true, items: [{ mimetype: 'image/jpg' }] },
+      { minimal: true, items: [{ mimetype: 'image/png' }] },
+      { minimal: true, items: [{ mimetype: 'image/jpg' }] },
+      { minimal: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { minimal: true, items: [{ mimetype: 'image/png' }] },
+      { minimal: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { minimal: true, items: [{ mimetype: 'image/jpg' }] },
+      { minimal: true, items: [{ mimetype: 'image/png' }] },
+      { minimal: true, items: [{ mimetype: 'image/jpg' }] }
+    ])
+  })
+
+  // types other than image or audio should be `minimal`
+  it('non-image/audio', () => {
+    let local
+    local = {
+      attachments: [
+        { mimetype: 'plain/text' }
+      ]
+    }
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { minimal: true, items: [{ mimetype: 'plain/text' }] }
+    ])
+
+    // No grouping of non-image/audio items
+    local = {
+      attachments: [
+        { mimetype: 'plain/text' },
+        { mimetype: 'plain/text' },
+        { mimetype: 'plain/text' }
+      ]
+    }
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { minimal: true, items: [{ mimetype: 'plain/text' }] },
+      { minimal: true, items: [{ mimetype: 'plain/text' }] },
+      { minimal: true, items: [{ mimetype: 'plain/text' }] }
+    ])
+
+    local = {
+      attachments: [
+        { mimetype: 'image/png' },
+        { mimetype: 'plain/text' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'audio/mpeg' }
+      ]
+    }
+    // NOTE / TODO: When defining `size: hide`, the `items` aren't
+    // grouped and `audio` isn't set
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { items: [{ mimetype: 'image/png' }] },
+      { minimal: true, items: [{ mimetype: 'plain/text' }] },
+      { items: [{ mimetype: 'image/jpg' }] },
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] }
+    ])
+  })
+
+  it('mixed attachments', () => {
+    local = {
+      attachments: [
+        { mimetype: 'audio/mpeg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'audio/mpeg' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/jpg' }
+      ]
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/png' }] },
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }, { mimetype: 'image/jpg' }, { mimetype: 'image/jpg' }] }
+    ])
+
+    local = {
+      attachments: [
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'audio/mpeg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'audio/mpeg' }
+      ]
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }, { mimetype: 'image/jpg' }] },
+      { items: [{ mimetype: 'image/jpg' }] },
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/png' }] },
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] }
+    ])
+
+    local = {
+      attachments: [
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' }
+      ]
+    }
+
+    // Group by three-per-row, unless there's one dangling, then stick it on the end of the last row
+    // https://git.pleroma.social/pleroma/pleroma-fe/-/merge_requests/1785#note_98514
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }, { mimetype: 'image/jpg' }] },
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }, { mimetype: 'image/png' }, { mimetype: 'image/jpg' }] }
+    ])
+
+    local = {
+      attachments: [
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/png' },
+        { mimetype: 'image/jpg' },
+        { mimetype: 'image/png' }
+      ]
+    }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }, { mimetype: 'image/jpg' }] },
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }, { mimetype: 'image/png' }] },
+      { items: [{ mimetype: 'image/jpg' }, { mimetype: 'image/png' }] }
+    ])
+  })
+
+  it('does not do grouping when grid is set', () => {
+    const attachments = [
+      { mimetype: 'audio/mpeg' },
+      { mimetype: 'image/png' },
+      { mimetype: 'audio/mpeg' },
+      { mimetype: 'image/jpg' },
+      { mimetype: 'image/png' },
+      { mimetype: 'image/jpg' },
+      { mimetype: 'image/jpg' }
+    ]
+
+    local = { grid: true, attachments }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { grid: true, items: attachments }
+    ])
+  })
+
+  it('limit is set', () => {
+    const attachments = [
+      { mimetype: 'audio/mpeg' },
+      { mimetype: 'image/png' },
+      { mimetype: 'image/jpg' },
+      { mimetype: 'audio/mpeg' },
+      { mimetype: 'image/jpg' }
+    ]
+
+    let local
+    local = { attachments, limit: 2 }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/png' }] }
+    ])
+
+    local = { attachments, limit: 3 }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/png' }, { mimetype: 'image/jpg' }] }
+    ])
+
+    local = { attachments, limit: 4 }
+
+    expect(Gallery.computed.rows.call(local)).to.eql([
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] },
+      { items: [{ mimetype: 'image/png' }, { mimetype: 'image/jpg' }] },
+      { audio: true, items: [{ mimetype: 'audio/mpeg' }] }
+    ])
+  })
+})

From 32d82f10d9e8ffd8b55f777f8865087981abdea7 Mon Sep 17 00:00:00 2001
From: Henry Jameson <me@hjkos.com>
Date: Sat, 21 Sep 2024 11:56:34 +0300
Subject: [PATCH 2/2] remove .only

---
 test/unit/specs/components/gallery.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unit/specs/components/gallery.spec.js b/test/unit/specs/components/gallery.spec.js
index 108e2b6b..3c92ae26 100644
--- a/test/unit/specs/components/gallery.spec.js
+++ b/test/unit/specs/components/gallery.spec.js
@@ -1,6 +1,6 @@
 import Gallery from 'src/components/gallery/gallery.vue'
 
-describe.only('Gallery', () => {
+describe('Gallery', () => {
   let local
 
   it('attachments is falsey', () => {