From eef151e7a670ea8dd56d7a497d740cf23ddfd5bf Mon Sep 17 00:00:00 2001 From: Matrix-Sasuke Date: Thu, 14 Nov 2024 11:48:57 +0100 Subject: [PATCH 1/3] fix bookmarks not showing on mobile --- src/components/navigation/navigation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/navigation/navigation.js b/src/components/navigation/navigation.js index 9fc264ba..efd5a420 100644 --- a/src/components/navigation/navigation.js +++ b/src/components/navigation/navigation.js @@ -33,7 +33,7 @@ export const TIMELINES = { route: 'bookmarks', icon: 'bookmark', label: 'nav.bookmarks', - criteria: ['!supportsBookmarkFolders'] + criteria: ['!supportsBookmarkFolders', 'supportsBookmarkFolders'] }, favorites: { routeObject: { name: 'user-profile', query: { tab: 'favorites' } }, From 4fcd51122598dbe51bc85c6c193cbfdb15a5da20 Mon Sep 17 00:00:00 2001 From: Matrix-Sasuke Date: Thu, 14 Nov 2024 12:36:31 +0100 Subject: [PATCH 2/3] fix bookmarks not showing on mobile --- changelog.d/show-bookmarks-on-mobile.fix | 1 + src/components/navigation/navigation.js | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 changelog.d/show-bookmarks-on-mobile.fix diff --git a/changelog.d/show-bookmarks-on-mobile.fix b/changelog.d/show-bookmarks-on-mobile.fix new file mode 100644 index 00000000..620c3c63 --- /dev/null +++ b/changelog.d/show-bookmarks-on-mobile.fix @@ -0,0 +1 @@ +Bookmarks on mobile were no longer showing diff --git a/src/components/navigation/navigation.js b/src/components/navigation/navigation.js index efd5a420..face430e 100644 --- a/src/components/navigation/navigation.js +++ b/src/components/navigation/navigation.js @@ -32,8 +32,7 @@ export const TIMELINES = { bookmarks: { route: 'bookmarks', icon: 'bookmark', - label: 'nav.bookmarks', - criteria: ['!supportsBookmarkFolders', 'supportsBookmarkFolders'] + label: 'nav.bookmarks' }, favorites: { routeObject: { name: 'user-profile', query: { tab: 'favorites' } }, From 27d2ac6f6629f7ac10b2a572d21af124a18ab951 Mon Sep 17 00:00:00 2001 From: Matrix-Sasuke Date: Thu, 14 Nov 2024 17:23:05 +0100 Subject: [PATCH 3/3] fix bookmarks not showing on mobile properly --- changelog.d/show-bookmarks-on-mobile.fix | 2 +- src/components/navigation/navigation.js | 3 ++- src/components/side_drawer/side_drawer.vue | 15 +++++++++++++++ 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/changelog.d/show-bookmarks-on-mobile.fix b/changelog.d/show-bookmarks-on-mobile.fix index 620c3c63..3b5db483 100644 --- a/changelog.d/show-bookmarks-on-mobile.fix +++ b/changelog.d/show-bookmarks-on-mobile.fix @@ -1 +1 @@ -Bookmarks on mobile were no longer showing +Bookmarks visible again on mobile diff --git a/src/components/navigation/navigation.js b/src/components/navigation/navigation.js index face430e..9fc264ba 100644 --- a/src/components/navigation/navigation.js +++ b/src/components/navigation/navigation.js @@ -32,7 +32,8 @@ export const TIMELINES = { bookmarks: { route: 'bookmarks', icon: 'bookmark', - label: 'nav.bookmarks' + label: 'nav.bookmarks', + criteria: ['!supportsBookmarkFolders'] }, favorites: { routeObject: { name: 'user-profile', query: { tab: 'favorites' } }, diff --git a/src/components/side_drawer/side_drawer.vue b/src/components/side_drawer/side_drawer.vue index 608b5608..91b10ea0 100644 --- a/src/components/side_drawer/side_drawer.vue +++ b/src/components/side_drawer/side_drawer.vue @@ -76,6 +76,21 @@ /> {{ $t("nav.lists") }} +
  • + + {{ $t("nav.bookmarks") }} + +